This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH, testsuite] Fix PR64796: bswap64 effective target should not cache its result

From: Jeff Law <law at redhat dot com>
To: "Thomas Preud'homme" <thomas dot preudhomme at arm dot com>, gcc-patches at gcc dot gnu dot org, Rainer Orth <ro at CeBiTec dot Uni-Bielefeld dot DE>, Mike Stump <mikestump at comcast dot net>, Janis Johnson <janisjo at codesourcery dot com>
Date: Tue, 03 Feb 2015 11:58:27 -0700
Subject: Re: [PATCH, testsuite] Fix PR64796: bswap64 effective target should not cache its result
Authentication-results: sourceware.org; auth=none
References: <001501d03a14$b3cbf6f0$1b63e4d0$ at arm dot com>

On 01/27/15 02:36, Thomas Preud'homme wrote:

As explained in PR64796, code for bswap64 effective target computes the answer once and then cache. However the result depends on the flags passed to the compiler and with --target_board it's possible to test several sets of flags. Besides, this code assume only lp64 targets can do 64-bit bswap when all 32-bit targets also can by virtue of expand_doubleword_bswap () called in expand_unop (). This patch solve both problems by removing the caching of the result and changing the condition to include all target with 32-bit or more wordsize.

ChangeLog entry is as follows:

**** gcc/testsuite/ChangeLog ***

2015-01-27  Thomas Preud'homme  <thomas.preudhomme@arm.com>

         PR testsuite/64796
         * lib/target-supports.exp (check_effective_target_bswap64): Do not
         cache result in a global variable.  Include all 32-bit targets for
         bswap64 tests.

OK.
jeff

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]