This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [Ping] Port of VTV for Cygwin and MinGW
- From: Jakub Jelinek <jakub at redhat dot com>
- To: Matthias Klose <doko at ubuntu dot com>
- Cc: "H.J. Lu" <hjl dot tools at gmail dot com>, Caroline Tice <cmtice at google dot com>, Patrick Wollgast <patrick dot wollgast at rub dot de>, Kai Tietz <ktietz70 at googlemail dot com>, Benjamin De Kosnik <bkoz at gnu dot org>, "jwakely at redhat dot com >> Jonathan Wakely" <jwakely at redhat dot com>, gcc-patches <gcc-patches at gcc dot gnu dot org>, "libstdc++ at gcc dot gnu dot org" <libstdc++ at gcc dot gnu dot org>
- Date: Thu, 29 Jan 2015 19:26:41 +0100
- Subject: Re: [Ping] Port of VTV for Cygwin and MinGW
- Authentication-results: sourceware.org; auth=none
- References: <CAKOQZ8w9_5OJEfnWJ-rgBgVzOzQcEj984MQcp=R1w=0JLUU8mw at mail dot gmail dot com> <54B77230 dot 6070704 at rub dot de> <CAKOQZ8wCM4+0guCsqzeFZjgUu-Y81NX9RbGhV-i7xz8_OVuMyQ at mail dot gmail dot com> <54B83638 dot 7080509 at rub dot de> <54C8C89C dot 1000104 at rub dot de> <CABtf2+R2kY+tv7Wk+rtnU6s55RbMmSgejqeWn11rqb7PHA-COA at mail dot gmail dot com> <54CA737A dot 5060102 at ubuntu dot com> <54CA767F dot 9040102 at ubuntu dot com> <CAMe9rOohc7imtMstqRBJCnbUsms9DNDgYO=GcYmjao9b0c9Szg at mail dot gmail dot com> <54CA78F1 dot 1020204 at ubuntu dot com>
- Reply-to: Jakub Jelinek <jakub at redhat dot com>
On Thu, Jan 29, 2015 at 07:16:17PM +0100, Matthias Klose wrote:
> On 01/29/2015 07:12 PM, H.J. Lu wrote:
> > On Thu, Jan 29, 2015 at 10:05 AM, Matthias Klose <doko@ubuntu.com> wrote:
> >> that fixes the build failure. ok to commit?
> >>
> >> 2015-01-29 Matthias Klose <doko@ubuntu.com>
> >>
> >> * acinclude.m4 (GLIBCXX_ENABLE_VTABLE_VERIFY): Define VTV_CYGMIN
> >> unconditionally.
> >> * configure: Regenerate.
> >>
> >
> > This is wrong. You are checking vtv_cygmin before it is defined.
>
> my bad, somebody should obviously build both variants ... now testing this variant.
Even with this patch vtv_cygmin is uninitialized. It will be likely empty
string, unless somebody has vtv_cygmin in the environment, but it is better
to initialize it, see the patch I've posted.
> --- acinclude.m4 (revision 220257)
> +++ acinclude.m4 (working copy)
> @@ -2320,8 +2320,6 @@
> AC_MSG_CHECKING([for vtable verify support])
> AC_MSG_RESULT([$enable_vtable_verify])
>
> - AM_CONDITIONAL(VTV_CYGMIN, test $vtv_cygmin = yes)
> -
> if test $enable_vtable_verify = yes; then
> case ${target_os} in
> cygwin*|mingw32*)
> @@ -2341,6 +2339,8 @@
> VTV_CXXLINKFLAGS=
> fi
>
> + AM_CONDITIONAL(VTV_CYGMIN, test $vtv_cygmin = yes)
> +
> AC_SUBST(VTV_CXXFLAGS)
> AC_SUBST(VTV_PCH_CXXFLAGS)
> AC_SUBST(VTV_CXXLINKFLAGS)
>
Jakub