This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [fixincludes] Fix <iso/math_c99.h> signbit on Solaris
- From: Bruce Korb <bkorb at gnu dot org>
- To: Rainer Orth <ro at CeBiTec dot Uni-Bielefeld dot DE>
- Cc: GCC Patches <gcc-patches at gcc dot gnu dot org>, "Joseph S. Myers" <joseph at codesourcery dot com>
- Date: Wed, 28 Jan 2015 10:13:40 -0800
- Subject: Re: [fixincludes] Fix <iso/math_c99.h> signbit on Solaris
- Authentication-results: sourceware.org; auth=none
- References: <CAKRnqNLoVJ6hBKwWR9gA78mCgM+jH4eNc7L=scL9y87FCH19Wg at mail dot gmail dot com> <yddh9vbj8oz dot fsf at lokon dot CeBiTec dot Uni-Bielefeld dot DE>
- Reply-to: bkorb at gnu dot org
Hi Rainer,
Sorry for the long delay. Anyway:
On 01/28/15 06:12, Rainer Orth wrote:
* In test_text, I had to backslash-escape the trailing \, otherwise they
were eaten up. Whether or not I do this makes no difference for the
generated fixincl.x, but only with the escaping does make check pass.
Right. It likely gets massaged by a shell script somewhere.
Line 88 of check.tpl:
88 cat >> [= (raw-shell-str (if (exist? "files") (get "files[0]") "testing.h"))
89 =] <<_HACK_EOF_
90
91
92 #if defined( [=(. HACK)=]_CHECK )
93 [=test_text=]
94 #endif /* [=(. HACK)=]_CHECK */
95 _HACK_EOF_
By quoting the "_HACK_EOF_" delimiter on line 89, the shell will not
try to process the "test_text".
This is certainly something that needs to be decided: if we go this
route, we should bump the autogen version requirement in install.texi
(to whatever is necessary to support the TAB\ magic).
I think Debian stable has moved up to 5.18.2, if I am remembering
correctly. It's a year old (last fall). I think that is old enough to
have been spread around by now.
It's your call ultimately.
OK, let's bump the defined requirement to something (almost) in this decade,
even if (for the moment) we don't use the TAB\ magic:
rel5.9.8/ 16-May-2009