This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[PATCH][libstdc++][testsuite][reverted] Remove check for truncation overflow


Hi all,

This patch reverts the libstdc++ hunk of https://gcc.gnu.org/ml/gcc-patches/2014-12/msg00768.html, that is the check for relocation truncation and the marking of the test as UNSUPPORTED if it occurs. The problem with this approach is that when we call 'unsupported "message"' in the .exp file the test is marked as UNSUPPORTED, but since we return the empty string, the test harness adds a PASS (test for excess errors) and marks it as UNRESOLVED. So instead of having a FAIL+UNRESOLVED for each test we get an UNSUPPORTED+PASS+UNRESOLVED. While it's nice to not have the FAILs, the latter combination confuses various results compare scripts and is not very helpful.

I couldn't figure out a way to remove the PASS+UNRESOLVED part from the libstdc++ testsuite and leave just the UNSUPPORTED message,
so I'm reverting that check until I figure out how to do it properly.
AFAIK this doesn't affect anything beyond aarch64 tests with -mcmodel=tiny

Committed with r220206.

Thanks,
Kyrill

2015-01-28  Kyrylo Tkachov  <kyrylo.tkachov@arm.com>

    * testsuite/lib/libstdc++.exp (v3_target_compile): Remove
    check for unsupported.
    (v3_target_compile_as_c): Likewise.
diff --git a/libstdc++-v3/testsuite/lib/libstdc++.exp b/libstdc++-v3/testsuite/lib/libstdc++.exp
index 05ca7d9..b2f7d00 100644
--- a/libstdc++-v3/testsuite/lib/libstdc++.exp
+++ b/libstdc++-v3/testsuite/lib/libstdc++.exp
@@ -486,12 +486,7 @@ proc v3_target_compile { source dest type options } {
     lappend options "timeout=[timeout_value]"
 
     set comp_output [target_compile $source $dest $type $options]
-    set unsupported_message [${tool}_check_unsupported_p $comp_output]
 
-    if { $unsupported_message != "" } {
-      unsupported "$dest: $unsupported_message"
-      return ""
-    }
     return $comp_output
 }
 
@@ -562,12 +557,7 @@ proc v3_target_compile_as_c { source dest type options } {
     lappend options "timeout=[timeout_value]"
 
     set comp_output [target_compile $source $dest $type $options]
-    set unsupported_message [${tool}_check_unsupported_p $comp_output]
 
-    if { $unsupported_message != "" } {
-      unsupported "$dest: $unsupported_message"
-      return ""
-    }
     return $comp_output
 }
 

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]