This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
RE: [PATCH MIPS RFA] Regression cleanup for nan2008 toolchain
- From: "Moore, Catherine" <Catherine_Moore at mentor dot com>
- To: Robert Suchanek <Robert dot Suchanek at imgtec dot com>, "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>
- Cc: Matthew Fortune <Matthew dot Fortune at imgtec dot com>
- Date: Mon, 26 Jan 2015 16:07:22 +0000
- Subject: RE: [PATCH MIPS RFA] Regression cleanup for nan2008 toolchain
- Authentication-results: sourceware.org; auth=none
- References: <B5E67142681B53468FAF6B7C313565624411910F at hhmail02 dot hh dot imgtec dot org>
> -----Original Message-----
> From: Robert Suchanek [mailto:Robert.Suchanek@imgtec.com]
> Sent: Monday, January 26, 2015 6:48 AM
> To: gcc-patches@gcc.gnu.org
> Cc: Matthew Fortune; Moore, Catherine
> Subject: [PATCH MIPS RFA] Regression cleanup for nan2008 toolchain
>
> Hi,
>
> Here is a patch to clean up a large number of reported failures when a
> toolchain
> is configured with --with-nan=2008 for mips*-linux-gnu triplet and clean up a
> failures
> for mips-img-linux-gnu where nan2008 is set by the default.
>
> In the former case, regression involves testing e.g. -mips4 with default
> options which
> causes emission of warnings that the -mips4 architecture does not support
> nan2008, and
> hence, the test is classified as a fail ("test for excess errors" type of error).
> The patch implies -mnan=legacy switch for all tests that are run for ISA rev <
> 2.
>
> In the latter case, even if we decrease the ISA level for incompatible options
> for
> the loongson vector extension tests, especially loongson-simd.c, a test that
> includes
> stdint.h or stdlib.h will end up including the glibc header 'stubs-<abi>.h>' and
> will
> fail as the mipsr6 toolchain will only have stubs-o32_hard_2008.h. A toolchain
> supporting
> nan1985 will have the required stubs-o32_hard.h. The only neat solution
> AFAICS was to add
> a new effective target that tries to compile and include stdlib.h to check if we
> have
> the proper support for the legacy NaN marking the concerned tests as
> UNSUPPORTED.
>
> Regards,
> Robert
>
> 2015-01-26 Robert Suchanek <robert.suchanek@imgtec.com>
>
> gcc/testsuite
> * lib/target-supports.exp (check_effective_target_mips_nanlegacy):
> New.
> * gcc.target/mips/loongson-simd.c: Require legacy NaN support.
> * gcc.target/mips/mips.exp (mips-dg-options): Imply -mnan=legacy
> for
> ISA rev < 2.
> ---
This patch is OK.