This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: Use static chain and libffi for Go closures
- From: Ian Lance Taylor <iant at golang dot org>
- To: Uros Bizjak <ubizjak at gmail dot com>
- Cc: "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>, Richard Henderson <rth at redhat dot com>, "gofrontend-dev at googlegroups dot com" <gofrontend-dev at googlegroups dot com>
- Date: Mon, 19 Jan 2015 20:18:13 -0800
- Subject: Re: Use static chain and libffi for Go closures
- Authentication-results: sourceware.org; auth=none
- References: <CAFULd4Y9ySbKrk2GHnAa3breDj=81Sx74tDY8JaWxetS6WN+AQ at mail dot gmail dot com> <CAOyqgcU=8h-+hi8+RNdges6h5YHcjQw8r4GafdmagnpMoNLgsQ at mail dot gmail dot com> <CAFULd4YpwuuoVvSnhwPbs4XcWJGqsfW-d9sva3JC7pKgubPOPw at mail dot gmail dot com>
On Sat, Jan 17, 2015 at 10:34 AM, Uros Bizjak <ubizjak@gmail.com> wrote:
> On Sat, Jan 17, 2015 at 12:19 AM, Ian Lance Taylor <iant@golang.org> wrote:
>
>>> You should also revert alpha specific change to
>>> libgo/go/testing/quick/quick_test.go, please see [1] and [2].
>>>
>>> [1] https://gcc.gnu.org/ml/gcc-patches/2013-03/msg00038.html
>>> [2] https://gcc.gnu.org/ml/gcc-patches/2013-03/msg00038/foo.patch
>>
>> Done like so. Committed to mainline.
>
> Thanks!
>
> There is another part in runtime/go-ffi.c that looks like it is not
> necessary anymore with FFI_TARGET_HAS_COMPLEX_TYPE.
>
> Attached proto-patch that removes special Complex64 handling survives
> go regression test for i686 target. However, some of i686 targets
> don't define FFI_TARGET_HAS_COMPLEX_TYPE, so at least this part should
> be conditional on !ifndef FFI_TARGET_HAS_COMPLEX_TYPE.
Thanks. Committed based on Richard H's later comments.
Ian