Re: [PATCH] IPA ICF: add comparison for target and optimization nodes

[Martin Liška <mliska at suse dot cz>]

On 01/15/2015 05:20 PM, Rainer Orth wrote:
> Martin Liška <mliska@suse.cz> writes:
>
> > On 01/07/2015 12:38 PM, Martin Liška wrote:
> > > Hello.
> > >
> > > Following patch adds support for target and optimization nodes
> > > comparison, which is
> > > based on Honza's newly added infrastructure.
> > >
> > > Apart from that, there's a small hunk that corrects formatting and
> > > removes unnecessary
> > > call to a comparison function.
> > >
> > > Hope it can be applied as one patch.
> > >
> > > Tested on x86_64-linux-pc without any new regression introduction.
> > >
> > > Ready for trunk?
> > >
> > > Thank you,
> > > Martin
> >
> > Hello.
> >
> > Apart from the previous patch, I would like to install following patch
> > which introduces
> > new dump functions related to target and optimization nodes. These
> > functions dump just
> > different flags.
> >
> > Patch has been tested on x86_64-linux-pc.
>
> Unfortunately, this patch breaks Solaris/SPARC bootstrap:
>
> options-save.c:3267:34: error: unused parameter 'indent' [-Werror=unused-parameter]
>                                int indent,
>                                    ^
> options-save.c:3268:55: error: unused parameter 'ptr1' [-Werror=unused-parameter]
>                                struct cl_target_option *ptr1,
>                                                         ^
> options-save.c:3269:55: error: unused parameter 'ptr2' [-Werror=unused-parameter]
>                                struct cl_target_option *ptr2)
>                                                         ^
>
> The following patch fixes this and allow the bootstrap to continue.
>
> 2015-01-15  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
>
> 	* optc-save-gen.awk (cl_target_option_print_diff): Mark indent,
> 	ptr1, ptr2 unused.
>
>
>
>
> Ok for mainline?
>
> 	Rainer

Hello Rainer.

Thank you for the patch.

Martin