This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] IPA ICF: add comparison for target and optimization nodes
- From: Rainer Orth <ro at CeBiTec dot Uni-Bielefeld dot DE>
- To: Martin Liška <mliska at suse dot cz>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Thu, 15 Jan 2015 17:20:33 +0100
- Subject: Re: [PATCH] IPA ICF: add comparison for target and optimization nodes
- Authentication-results: sourceware.org; auth=none
- References: <54AD1AB3 dot 2060904 at suse dot cz> <54AFAF0E dot 9070203 at suse dot cz>
Martin Liška <mliska@suse.cz> writes:
> On 01/07/2015 12:38 PM, Martin Liška wrote:
>> Hello.
>>
>> Following patch adds support for target and optimization nodes
>> comparison, which is
>> based on Honza's newly added infrastructure.
>>
>> Apart from that, there's a small hunk that corrects formatting and
>> removes unnecessary
>> call to a comparison function.
>>
>> Hope it can be applied as one patch.
>>
>> Tested on x86_64-linux-pc without any new regression introduction.
>>
>> Ready for trunk?
>>
>> Thank you,
>> Martin
>
> Hello.
>
> Apart from the previous patch, I would like to install following patch
> which introduces
> new dump functions related to target and optimization nodes. These
> functions dump just
> different flags.
>
> Patch has been tested on x86_64-linux-pc.
Unfortunately, this patch breaks Solaris/SPARC bootstrap:
options-save.c:3267:34: error: unused parameter 'indent' [-Werror=unused-parameter]
int indent,
^
options-save.c:3268:55: error: unused parameter 'ptr1' [-Werror=unused-parameter]
struct cl_target_option *ptr1,
^
options-save.c:3269:55: error: unused parameter 'ptr2' [-Werror=unused-parameter]
struct cl_target_option *ptr2)
^
The following patch fixes this and allow the bootstrap to continue.
2015-01-15 Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
* optc-save-gen.awk (cl_target_option_print_diff): Mark indent,
ptr1, ptr2 unused.
diff --git a/gcc/optc-save-gen.awk b/gcc/optc-save-gen.awk
--- a/gcc/optc-save-gen.awk
+++ b/gcc/optc-save-gen.awk
@@ -505,9 +505,9 @@ print "";
print "/* Print different target option variables from structures provided as arguments. */";
print "void";
print "cl_target_option_print_diff (FILE *file,";
-print " int indent,";
-print " struct cl_target_option *ptr1,";
-print " struct cl_target_option *ptr2)";
+print " int indent ATTRIBUTE_UNUSED,";
+print " struct cl_target_option *ptr1 ATTRIBUTE_UNUSED,";
+print " struct cl_target_option *ptr2 ATTRIBUTE_UNUSED)";
print "{";
print " fputs (\"\\n\", file);";
Ok for mainline?
Rainer
--
-----------------------------------------------------------------------------
Rainer Orth, Center for Biotechnology, Bielefeld University