Re: libgo patch committed: Update to Go 1.4

[Richard Biener <richard dot guenther at gmail dot com>]

On Thu, Jan 15, 2015 at 1:28 AM, Ian Lance Taylor <iant@golang.org> wrote:
> I've committed a patch to libgo to update it to the Go 1.4 release,
> except for the runtime package.  Much of the runtime package was
> rewritten in Go, and it does not really affect users of the library,
> so I've postponed that complex merge.  All the other packages are
> updated.  A few minor compiler changes were required, as well as a few
> changes to the runtime packages required for other changes.  The
> testsuite script was changed to add support for the new TestMain
> function, which is used by one or two of the standard packages.
>
> As usual with libgo updates the entire patch is too large to attach
> here.  I've attached the changes to configuration/build files and the
> runtime package.
>
> Note that the type descriptor format has changed very very slightly to
> include an additional flag.  This means that all existing Go files
> must be recompiled in order to work with this updated libgo.  I will
> bump the libgo version number shortly.
>
> Bootstrapped and ran Go testsuite on x86_64-unknown-linux-gnu.
> Committed to mainline.

Looks like this broke s390x:

[ 5286s] libtool: compile:  /home/abuild/rpmbuild/BUILD/gcc-5.0.0-r219634/obj-s3
90x-suse-linux/./gcc/gccgo -B/home/abuild/rpmbuild/BUILD/gcc-5.0.0-r219634/obj-s
390x-suse-linux/./gcc/ -B/usr/s390x-suse-linux/bin/ -B/usr/s390x-suse-linux/lib/
 -isystem /usr/s390x-suse-linux/include -isystem /usr/s390x-suse-linux/sys-inclu
de -O2 -g -I . -c -fgo-pkgpath=reflect ../../../libgo/go/reflect/deepequal.go ..
/../../libgo/go/reflect/makefunc.go ../../../libgo/go/reflect/makefunc_ffi.go ..
/../../libgo/go/reflect/makefuncgo_s390x.go ../../../libgo/go/reflect/makefuncgo
_s390.go ../../../libgo/go/reflect/type.go ../../../libgo/go/reflect/value.go  -
fPIC -o .libs/reflect-go.o
[ 5286s] ../../../libgo/go/reflect/makefuncgo_s390x.go:323:5: error: expected ';
' or '}' or newline
[ 5286s]    } else {
[ 5286s]      ^
[ 5286s] ../../../libgo/go/reflect/makefuncgo_s390x.go:336:2: error: expected '}
'
[ 5286s]   case s390x_mem_ptr:
[ 5286s]   ^
[ 5286s] ../../../libgo/go/reflect/makefuncgo_s390x.go:357:2: error: expected de
claration
[ 5286s]   return
[ 5286s]   ^

and more errors.

Richard.

> Ian
>
> gotools/ChangeLog:
>
> 2015-01-14  Ian Lance Taylor  <iant@google.com>
>
> * Makefile.am (go_cmd_go_files): Sort entries.  Add generate.go.
> * Makefile.in: Rebuild.