This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] PR59448 - Promote consume to acquire

From: Andrew MacLeod <amacleod at redhat dot com>
To: Joseph Myers <joseph at codesourcery dot com>
Cc: Torvald Riegel <triegel at redhat dot com>, Richard Biener <richard dot guenther at gmail dot com>, gcc-patches <gcc-patches at gcc dot gnu dot org>, Jeff Law <law at redhat dot com>
Date: Wed, 14 Jan 2015 16:31:16 -0500
Subject: Re: [PATCH] PR59448 - Promote consume to acquire
Authentication-results: sourceware.org; auth=none
References: <54B53203 dot 6030304 at redhat dot com> <CAFiYyc2E-+XCPQz1QEYuLg_Fes-McfZZCaHerujufKNQ77j7AA at mail dot gmail dot com> <54B53587 dot 9080803 at redhat dot com> <1421174335 dot 17929 dot 7 dot camel at triegel dot csb> <54B56CB0 dot 7000902 at redhat dot com> <alpine dot DEB dot 2 dot 10 dot 1501132231380 dot 10473 at digraph dot polyomino dot org dot uk> <54B68ECD dot 5070409 at redhat dot com> <alpine dot DEB dot 2 dot 10 dot 1501141828290 dot 20530 at digraph dot polyomino dot org dot uk>

On 01/14/2015 01:28 PM, Joseph Myers wrote:

On Wed, 14 Jan 2015, Andrew MacLeod wrote:

- There is a warning for invalid memory models already, so I just continued
using that.
- I remove the check for CONSUME in exchange since the current standard makes
no mention of that being illegal.
- I also reversed the current check in compare_exchange to check for failure >
success first, allowing us to still catch both errors if present.

I think this brings us to where we ought to be...   at least almost :-)
The latest version I have  is n3337, which still specifies that atomic_clear
can't be memory_order_acquire or memory_order_acq_rel. Has that been updated
to specify that memory_order_consume is not allowed either?  I think there was
a request in at some point...   I can add that if so.

Bootstraps on x86_64-unknown-linux-gnu, and no regressions in the testsuite.

OK for trunk?

OK.

checked in after disallowing memory_order_consume on atomic_clear() andan additional test in the testcase for that...


Andrew

References:
- [PATCH] PR59448 - Promote consume to acquire
  - From: Andrew MacLeod
- Re: [PATCH] PR59448 - Promote consume to acquire
  - From: Richard Biener
- Re: [PATCH] PR59448 - Promote consume to acquire
  - From: Andrew MacLeod
- Re: [PATCH] PR59448 - Promote consume to acquire
  - From: Torvald Riegel
- Re: [PATCH] PR59448 - Promote consume to acquire
  - From: Andrew MacLeod
- Re: [PATCH] PR59448 - Promote consume to acquire
  - From: Joseph Myers
- Re: [PATCH] PR59448 - Promote consume to acquire
  - From: Andrew MacLeod
- Re: [PATCH] PR59448 - Promote consume to acquire
  - From: Joseph Myers

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]