This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [Patch, Fortran, OOP] PR 63733: [4.8/4.9/5 Regression] wrong resolution for OPERATOR generics
- From: Janus Weil <janus at gcc dot gnu dot org>
- To: Paul Richard Thomas <paul dot richard dot thomas at gmail dot com>
- Cc: gfortran <fortran at gcc dot gnu dot org>, gcc-patches <gcc-patches at gcc dot gnu dot org>
- Date: Mon, 12 Jan 2015 17:18:22 +0100
- Subject: Re: [Patch, Fortran, OOP] PR 63733: [4.8/4.9/5 Regression] wrong resolution for OPERATOR generics
- Authentication-results: sourceware.org; auth=none
- References: <CAKwh3qj_XvUzB_4LQ4d3dAx11gCGMd6O9bS0-c_t7YL9EQi_YA at mail dot gmail dot com> <CAGkQGiJBFzesw3vpg7R-cpH5nWugv68YN_rnWjJcd56hn2BUAw at mail dot gmail dot com> <CAKwh3qiVVipYZnJDhd5sp+3pJWp_yT9XN0eB4GrW8Wrfo-qooQ at mail dot gmail dot com> <CAGkQGi+4Z5ZFRdfYzq=per1syQvvpokJ+K-ax=UBvFqW8jivQA at mail dot gmail dot com>
Good, I fully agree. Fortunately the patch applies cleanly to the 4.9
branch and regtests without errors. Thus I have applied it as r219475.
Will do 4.8 soon.
Cheers,
Janus
2015-01-12 9:30 GMT+01:00 Paul Richard Thomas <paul.richard.thomas@gmail.com>:
> Dear Janus,
>
> Since it is a regression, by all means update the branches. We
> usually, propose delaying a bit but I am not convinced that this is
> effective for this kind of bug fix - usually, further problems take a
> long time to emerge. Thus, I would recommend that you get on with it.
>
> Thanks
>
> Paul
>
> On 11 January 2015 at 23:01, Janus Weil <janus@gcc.gnu.org> wrote:
>>> Well done for sorting that out. OK for trunk.
>>
>> Thanks, Paul. Committed as r219440.
>>
>> What about the branches?
>>
>> Cheers,
>> Janus
>>
>>
>>
>>> On 11 January 2015 at 14:38, Janus Weil <janus@gcc.gnu.org> wrote:
>>>> Hi all,
>>>>
>>>> this patch fixes a wrong-code regression related to operators, by
>>>> making sure that we look for typebound operators first, before looking
>>>> for non-typebound ones. (Note: Each typebound operator is also added
>>>> to the list of non-typebound ones, for reasons of diagnostics.)
>>>>
>>>> Regtested on x86_64-unknown-linux-gnu. Ok for trunk? 4.9/4.8?
>>>>
>>>> Cheers,
>>>> Janus
>>>>
>>>>
>>>>
>>>> 2015-01-11 Janus Weil <janus@gcc.gnu.org>
>>>>
>>>> PR fortran/63733
>>>> * interface.c (gfc_extend_expr): Look for type-bound operators before
>>>> non-typebound ones.
>>>>
>>>> 2015-01-11 Janus Weil <janus@gcc.gnu.org>
>>>>
>>>> PR fortran/63733
>>>> * gfortran.dg/typebound_operator_20.f90: New.
>>>
>>>
>>>
>>> --
>>> Outside of a dog, a book is a man's best friend. Inside of a dog it's
>>> too dark to read.
>>>
>>> Groucho Marx
>
>
>
> --
> Outside of a dog, a book is a man's best friend. Inside of a dog it's
> too dark to read.
>
> Groucho Marx