This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Instrument bit field and unaligned accesses for TSAN
- From: Jakub Jelinek <jakub at redhat dot com>
- To: Bernd Edlinger <bernd dot edlinger at hotmail dot de>, Dmitry Vyukov <dvyukov at google dot com>
- Cc: "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>
- Date: Fri, 2 Jan 2015 22:29:01 +0100
- Subject: Re: [PATCH] Instrument bit field and unaligned accesses for TSAN
- Authentication-results: sourceware.org; auth=none
- References: <DUB118-W36BD6269214D3EE6E26A4AE4510 at phx dot gbl> <20150102190102 dot GB1667 at tucnak dot redhat dot com> <DUB118-W157955758BEE04CBCE299FE45D0 at phx dot gbl>
- Reply-to: Jakub Jelinek <jakub at redhat dot com>
On Fri, Jan 02, 2015 at 10:06:29PM +0100, Bernd Edlinger wrote:
> OK, I will do that.
> I removed the __tsan_vptr_update stuff from the patch, for now.
Guess we should ask Dmitry about that.
> It will probably be difficult for me to find a test case for this,
> because I am not really sure what __tsan_vptr_update is actually good for,
> (i.e. the use case).
> I think I should also change the function type of BUILT_IN_READ_RANGE
> and BUILT_IN_WRITE_RANGE to BT_FN_VOID_PTR_SIZE?
You should use BT_FN_VOID_PTR_PTRMODE for those instead, and you don't need to
initialize it in asan.c - it is already initialized there.
size_t might be a different integer type from uptr.
Jakub