This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Fix PR libstdc++/64422
- From: Jonathan Wakely <jwakely dot gcc at gmail dot com>
- To: Bernd Edlinger <bernd dot edlinger at hotmail dot de>
- Cc: Paolo Carlini <paolo dot carlini at oracle dot com>, "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>, "libstdc++ at gcc dot gnu dot org" <libstdc++ at gcc dot gnu dot org>
- Date: Fri, 2 Jan 2015 19:59:43 +0000
- Subject: Re: [PATCH] Fix PR libstdc++/64422
- Authentication-results: sourceware.org; auth=none
- References: <DUB118-W50B524C48E2D6AD0B80B46E45C0 at phx dot gbl> <CAH6eHdR_ZZJ1MiMgNrvdRbiOEV_tco5Bgmk4=C0Z9OpCN9pVbg at mail dot gmail dot com> <54A6BC32 dot 1090000 at oracle dot com> <DUB118-W31D695A3191199269F5244E45D0 at phx dot gbl>
On 2 January 2015 at 18:05, Bernd Edlinger wrote:
>
> Hi,
>
> On Fri, 2 Jan 2015 16:41:38, Paolo Carlini wrote:
>>
>> Hi,
>>
>> On 01/02/2015 04:33 PM, Jonathan Wakely wrote:
>>> The misc-inst.cc change looks good but as this is a libstdc++ bug the
>>> testcase should be under the libstdc++-v3/testsuite dir and the patch
>>> should be CC'd to the libstdc++ list.
>> ... and shouldn't be a dg-do run, I would add.
>>
>> Paolo.
>
> How about this? I verified that the test case is still able to detect
> the missing symbols.
> Actually I was not quite sure where to add the test case. Is it OK here?
It isn't testing the member types, so I think either in
21_strings/basic_string/ or 21_strings/basic_string/modifiers/ (since
all the missing symbols happen to be ones defined in the "modifiers"
subclause).
For some reason that I don't really know, we put the FSF copyright and
GPLv3+exception copying permission statement in all libstdc++ tests,
please see one of the existing tests for the exact wording.
OK for trunk after moving it to one of those other directories and
adding the copyright boilerplate - thanks very much for fixing it.