This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: Pragma parsing
- From: Jakub Jelinek <jakub at redhat dot com>
- To: Thomas Schwinge <thomas at codesourcery dot com>
- Cc: gcc-patches at gcc dot gnu dot org, jason at redhat dot com, James Norris <jnorris at codesourcery dot com>, Chung-Lin Tang <cltang at codesourcery dot com>, Joseph Myers <joseph at codesourcery dot com>
- Date: Fri, 19 Dec 2014 13:41:57 +0100
- Subject: Re: Pragma parsing
- Authentication-results: sourceware.org; auth=none
- References: <545A9884 dot 4030203 at codesourcery dot com> <20141113130237 dot GM5026 at tucnak dot redhat dot com> <547DBBC9 dot 9040403 at codesourcery dot com> <87bnn1rrv3 dot fsf at schwinge dot name> <20141218142942 dot GM1667 at tucnak dot redhat dot com> <87r3vwrg7q dot fsf at schwinge dot name> <20141219103639 dot GU1667 at tucnak dot redhat dot com> <87ioh7rftn dot fsf at schwinge dot name>
- Reply-to: Jakub Jelinek <jakub at redhat dot com>
On Fri, Dec 19, 2014 at 01:20:52PM +0100, Thomas Schwinge wrote:
> Hi Jakub!
>
> On Fri, 19 Dec 2014 11:36:39 +0100, Jakub Jelinek <jakub@redhat.com> wrote:
> > On Thu, Dec 18, 2014 at 07:00:09PM +0100, Thomas Schwinge wrote:
> > > > The point is that we now have lots of clauses, and making it clear what from
> > > > those clauses are Cilk+, what are OpenACC, what are OpenMP will help with
> > > > code readability.
> >
> > So here is what I'd like to see with PRAGMA_O*_CLAUSE_*, it matches what we
> > do already for Cilk+ and at least to me makes the code more readable.
>
> Thanks for the patch! OK, so that's what you meant. So be it. :-)
>
> > gomp-4_0-branch compiles with it, haven't tested anything.
>
> Looks good, too. Are you going to commit your patch?
Done now, after writing ChangeLog for it.
2014-12-19 Jakub Jelinek <jakub@redhat.com>
c-family/
* c-pragma.h (enum pragma_omp_clause): Rename
OpenACC only clauses to PRAGMA_OACC_CLAUSE_* from
PRAGMA_OMP_CLAUSE_*. For clauses shared by OpenMP
and OpenACC add PRAGMA_OACC_CLAUSE_* aliases to
PRAGMA_OMP_CLAUSE_* values.
c/
* c-parser.c (c_parser_omp_clause_name): Use PRAGMA_OACC_CLAUSE_*
for OpenACC only clauses.
(c_parser_oacc_data_clause, c_parser_oacc_data_clause_deviceptr,
c_parser_oacc_all_clauses): Use PRAGMA_OACC_CLAUSE_* instead of
PRAGMA_OMP_CLAUSE_*.
(OACC_DATA_CLAUSE_MASK, OACC_KERNELS_CLAUSE_MASK,
OACC_ENTER_DATA_CLAUSE_MASK, OACC_EXIT_DATA_CLAUSE_MASK,
OACC_LOOP_CLAUSE_MASK, OACC_PARALLEL_CLAUSE_MASK,
OACC_UPDATE_CLAUSE_MASK, OACC_WAIT_CLAUSE_MASK): Likewise.
cp/
* parser.c (cp_parser_omp_clause_name): Use PRAGMA_OACC_CLAUSE_*
for OpenACC only clauses.
(cp_parser_oacc_data_clause, cp_parser_oacc_data_clause_deviceptr,
cp_parser_oacc_all_clauses): Use PRAGMA_OACC_CLAUSE_* instead of
PRAGMA_OMP_CLAUSE_*.
(OACC_DATA_CLAUSE_MASK, OACC_KERNELS_CLAUSE_MASK,
OACC_ENTER_DATA_CLAUSE_MASK, OACC_EXIT_DATA_CLAUSE_MASK,
OACC_LOOP_CLAUSE_MASK, OACC_PARALLEL_CLAUSE_MASK,
OACC_UPDATE_CLAUSE_MASK, OACC_WAIT_CLAUSE_MASK): Likewise.
Jakub