This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH 4/4] Data structure is used for inline_summary struct.
- From: Jan Hubicka <hubicka at ucw dot cz>
- To: Martin Liška <mliska at suse dot cz>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Thu, 18 Dec 2014 20:43:55 +0100
- Subject: Re: [PATCH 4/4] Data structure is used for inline_summary struct.
- Authentication-results: sourceware.org; auth=none
- References: <cd4c62522f43eb2d2ad92769431e91c8d8bd15bc dot 1415888515 dot git dot mliska at suse dot cz> <0747c9874be8f00250182794f2eb38d021464046 dot 1415888515 dot git dot mliska at suse dot cz> <20141113160431 dot GG11013 at kam dot mff dot cuni dot cz> <54660D21 dot 3030200 at suse dot cz> <54661E98 dot 4070309 at suse dot cz> <5485D9BD dot 40104 at suse dot cz>
>
> 2014-12-08 Martin Liska <mliska@suse.cz>
>
> * lto-partition.c (add_symbol_to_partition_1): New inline_summary_d
> is used.
> (undo_partition): Likewise.
> (lto_balanced_map): Likewise.
>
> gcc/ChangeLog:
>
> 2014-12-08 Martin Liska <mliska@suse.cz>
>
> * cgraphunit.c (symbol_table::process_new_functions): New inline_summary_d
> is used.
> * ipa-cp.c (ipcp_cloning_candidate_p): Likewise.
> (devirtualization_time_bonus): Likewise.
> (estimate_local_effects): Likewise.
> (ipcp_propagate_stage): Likewise.
> * ipa-inline-analysis.c (evaluate_conditions_for_known_args): Likewise.
> (evaluate_properties_for_edge): Likewise.
> (inline_summary_alloc): Likewise.
> (reset_inline_summary): New inline_summary argument is introduced.
> (inline_summary_t::remove): New function.
> (inline_summary_t::duplicate): Likewise.
> (dump_inline_edge_summary): New inline_summary_d is used.
> (dump_inline_summary): Likewise.
> (estimate_function_body_sizes): Likewise.
> (compute_inline_parameters): Likewise.
> (estimate_edge_devirt_benefit): Likewise.
> (estimate_node_size_and_time): Likewise.
> (inline_update_callee_summaries): Likewise.
> (inline_merge_summary): Likewise.
> (inline_update_overall_summary): Likewise.
> (simple_edge_hints): Likewise.
> (do_estimate_edge_time): Likewise.
> (estimate_time_after_inlining): Likewise.
> (estimate_size_after_inlining): Likewise.
> (do_estimate_growth): Likewise.
> (growth_likely_positive): Likewise.
> (inline_generate_summary): Likewise.
> (inline_read_section): Likewise.
> (inline_read_summary): Likewise.
> (inline_write_summary): Likewise.
> (inline_free_summary): Likewise.
> * ipa-inline-transform.c (clone_inlined_nodes): Likewise.
> (inline_call): Likewise.
> * ipa-inline.c (caller_growth_limits): Likewise.
> (can_inline_edge_p): Likewise.
> (want_early_inline_function_p): Likewise.
> (compute_uninlined_call_time): Likewise.
> (compute_inlined_call_time): Likewise.
> (big_speedup_p): Likewise.
> (want_inline_small_function_p): Likewise.
> (edge_badness): Likewise.
> (update_caller_keys): Likewise.
> (update_callee_keys): Likewise.
> (recursive_inlining): Likewise.
> (inline_small_functions): Likewise.
> (inline_to_all_callers): Likewise.
> (dump_overall_stats): Likewise.
> (early_inline_small_functions): Likewise.
> * ipa-inline.h: New class inline_summary_t replaces
> vec<inline_summary_t>.
> * ipa-split.c (execute_split_functions): New inline_summary_d is used.
> * ipa.c (walk_polymorphic_call_targets): Likewise.
> * tree-sra.c (ipa_sra_preliminary_function_checks): Likewise.
Patch is OK. I only changed mind about inline_summary_d. It does not look good used
with inline_summary_d->get() especially because _d prefix was used in C++ication days
for type names only.
Probably inline_summaries->get() is better.
OK with this change.
Thanks,
Honza