This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: PATCH: PR target/61296: Excessive alignment in ix86_data_alignment
- From: Uros Bizjak <ubizjak at gmail dot com>
- To: Jakub Jelinek <jakub at redhat dot com>
- Cc: "H.J. Lu" <hjl dot tools at gmail dot com>, "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>, Petr Murzin <petrmurzin1 at gmail dot com>, Kirill Yukhin <kirill dot yukhin at gmail dot com>
- Date: Wed, 17 Dec 2014 15:02:16 +0100
- Subject: Re: PATCH: PR target/61296: Excessive alignment in ix86_data_alignment
- Authentication-results: sourceware.org; auth=none
- References: <20141217131036 dot GA18450 at gmail dot com> <20141217131434 dot GW1667 at tucnak dot redhat dot com>
On Wed, Dec 17, 2014 at 2:14 PM, Jakub Jelinek <jakub@redhat.com> wrote:
> On Wed, Dec 17, 2014 at 05:10:36AM -0800, H.J. Lu wrote:
>> PR target/61296
>> * config/i386/i386-opts.h (ix86_align_data): New enum.
>> * config/i386/i386.c (ix86_data_alignment): Return the ABI
>> alignment value for -malign-data=abi, the cachine line size
>> for -malign-data=cachineline and the older GCC compatible
>> alignment value for for -malign-data=compat.
>> * config/i386/i386.opt (malign-data=): New.
>> * doc/invoke.texi: Document -malign-data=.
>>
>> gcc/testsuite/
>>
>> PR target/61296
>> * gcc.target/i386/pr61296-2.c: New.
>> * gcc.target/i386/pr61296-2.c: Likewise.
>> * gcc.target/i386/pr61296-3.c: Likewise.
>> * gcc.target/i386/pr61296-4.c: Likewise.
>> * gcc.target/i386/pr61296-5.c: Likewise.
>> * gcc.target/i386/pr61296-6.c: Likewise.
>> * gcc.target/i386/pr61296-7.c: Likewise.
>
> Otherwise LGTM, but I'll defer to Uros for final ack.
... psABI, and "cacheline" with increased alignment value to match the
cache line size. "compat" is the default.
s/with/uses/
The patch is OK for mainline with above substitution.
Thanks to everybody involved,
Uros.