This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Go patch committed: Don't crash on append with a single argument

From: Ian Lance Taylor <iant at golang dot org>
To: gcc-patches <gcc-patches at gcc dot gnu dot org>, "gofrontend-dev at googlegroups dot com" <gofrontend-dev at googlegroups dot com>
Date: Tue, 16 Dec 2014 17:04:56 -0800
Subject: Go patch committed: Don't crash on append with a single argument
Authentication-results: sourceware.org; auth=none

Gccgo was crashing when a program called append with a single
argument.  Doing this doesn't make sense, but of course the compiler
should not crash.  The crash was due to the code passing nil as the
second argument, then converting that to a slice composite literal.  A
slice composite literal needs a type, and this type was created too
late for the type descriptor to be created.  This patch finesses the
issue by creating a slice value with a nil pointer instead.  The test
case for this is https://go-review.googlesource.com/#/c/1692/ .
Bootstrapped and ran Go testsuite on x86_64-unknown-linux-gnu.
Committed to mainline.

Ian

Attachment: foo.txt
Description: Text document

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]