This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Make dg-extract-results.sh explicitly treat .{sum,log} files as text
- From: Jakub Jelinek <jakub at redhat dot com>
- To: Sergio Durigan Junior <sergiodj at redhat dot com>
- Cc: GCC Patches <gcc-patches at gcc dot gnu dot org>
- Date: Mon, 15 Dec 2014 23:46:08 +0100
- Subject: Re: [PATCH] Make dg-extract-results.sh explicitly treat .{sum,log} files as text
- Authentication-results: sourceware.org; auth=none
- References: <1418683023-26087-1-git-send-email-sergiodj at redhat dot com>
- Reply-to: Jakub Jelinek <jakub at redhat dot com>
On Mon, Dec 15, 2014 at 05:37:03PM -0500, Sergio Durigan Junior wrote:
> 2014-12-14 Sergio Durigan Junior <sergiodj@redhat.com>
>
> * dg-extract-results.sh: Pass '--text' option to grep when
> filtering .{sum,log} files, which may contain binary data.
I'd be surprised if all versions of grep supported --text option (e.g. POSIX
doesn't mention the -a nor --text options), guess
you'd need to check for that first (early in the script) and add it only if
it works. Also, supposedly the options should come before the regexp and
list of files. Why isn't the python version used in your case btw?
Jakub