Re: [PATCH] libgccjit cleanups

[David Malcolm <dmalcolm at redhat dot com>]

On Wed, 2014-12-10 at 23:32 -0500, Ulrich Drepper wrote:
> On Mon, Dec 8, 2014 at 11:36 AM, David Malcolm <dmalcolm@redhat.com> wrote:
> > Thanks.  Overall this is good, a few nitpicks inline below:
> 
> I've made the changes and checked in the patch.

...as r218617.  Thanks.

The jit subdirectory has its own ChangeLog file.  I realize now that
your ChangeLog entries went in gcc/ChangeLog; they should have been in
gcc/jit/ChangeLog.

Sorry for not spotting that in review.  I've fixed it in r218637.

Does your editor do some kind of auto-reindent?  FWIW, I see various
whitespace-only changes in that commit.  I assume we try to avoid such
changes 

I've added documentation of libgccjit++.h to the .rst files as of
yesterday.  So I've added documentation of the new function as r218636:

gcc/jit/ChangeLog:
	* docs/cp/topics/contexts.rst (gccjit::context::set_str_option):
	Document new function.
	* docs/_build/texinfo/libgccjit.texi: Regenerate.

---
 gcc/jit/docs/cp/topics/contexts.rst | 15 ++++++++++++---
 1 file changed, 12 insertions(+), 3 deletions(-)

diff --git a/gcc/jit/docs/cp/topics/contexts.rst b/gcc/jit/docs/cp/topics/contexts.rst
index 72815fb..4becd51 100644
--- a/gcc/jit/docs/cp/topics/contexts.rst
+++ b/gcc/jit/docs/cp/topics/contexts.rst
@@ -148,9 +148,18 @@ Debugging
 Options
 -------
 
-..
-  FIXME: gccjit::context::set_str_option doesn't seem to exist yet in the
-  C++ API
+String Options
+**************
+
+.. function:: void \
+              gccjit::context::set_str_option (enum gcc_jit_str_option, \
+                                               const char *value)
+
+   Set a string option of the context.
+
+   This is a thin wrapper around the C API
+   :c:func:`gcc_jit_context_set_str_option`; the options have the same
+   meaning.
 
 Boolean options
 ***************
-- 
1.8.5.3