This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] check_GNU_style.sh "80 characters exceeded" error fix
- From: Jeff Law <law at redhat dot com>
- To: Mantas Mikaitis <Mantas dot Mikaitis at arm dot com>, gcc-patches at gcc dot gnu dot org
- Date: Mon, 08 Dec 2014 15:15:46 -0700
- Subject: Re: [PATCH] check_GNU_style.sh "80 characters exceeded" error fix
- Authentication-results: sourceware.org; auth=none
- References: <5473371E dot 9000904 at arm dot com> <547337E2 dot 80000 at arm dot com>
On 11/24/14 06:51, Mantas Mikaitis wrote:
check_GNU_style.sh error "Lines should not exceed 80 characters" does
not return the file name and line number where error is present,
only the line of code. Whereas other kind of errors return full
information.
This small patch will fix this and make check_GNU_style.sh return full
information when patch contains lines longer than 80 errors.
Tested on patches containing >80 chars lines and the script produces
full information as necessary.
Would this be a useful enhancement for trunk?
Mantas Mikaitis
gcc/ChangeLog:
* contrib/check_GNU_style.sh (col): Got rid of cut operation
from the pipe chain and instead added cut inside awk command.
Yes. Please install on the trunk.
Thanks,
Jeff