Re: [RFC PATCH fortran/diagnostics] Move gfc_error (buffered) to common diagnostics

[Tobias Burnus <burnus at net-b dot de>]

Manuel López-Ibáñez wrote:
> I separated the diagnostics and fortran parts in two patches. This is a RFC to:
>
> * Dodji: I needed to make diagnostic_action_after_output external. [...]
>
> * Tobias or other Fortran maintainers. The only test failing is
> gfortran.dg/do_iterator.f90 line 7. The old code gives an Error there,
> which the new one does not.
>     READ(5,*) I ! { dg-error "cannot be redefined" "changing do-iterator 2" }
>           1
> Error: Invalid character in name at (1)

That error looks bogus: The message (semantically) looks odd and also 
the whole test case doesn't give the impression that that message was 
intented. Thus, your new patch seems to be ok.

> (Tobias, there are some cleanups in the fortran patch in error.c to
> use 'bool' more often for some flags and functions. If you want to
> apply that already, it will reduce the diff a bit.)

I did do so now.


Regarding the patch: For gfc_error_check, I think you need to set "rc" 
(now: "error_raised") also when the new code is used. Otherwise, it 
looks good to me. Thanks for working on it!

Tobias