This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH x86] Enable v64qi permutations.
- From: Uros Bizjak <ubizjak at gmail dot com>
- To: Jakub Jelinek <jakub at redhat dot com>
- Cc: "H.J. Lu" <hjl dot tools at gmail dot com>, Ilya Tocar <tocarip dot intel at gmail dot com>, GCC Patches <gcc-patches at gcc dot gnu dot org>
- Date: Thu, 4 Dec 2014 13:45:11 +0100
- Subject: Re: [PATCH x86] Enable v64qi permutations.
- Authentication-results: sourceware.org; auth=none
- References: <20141204094959 dot GA67582 at msticlxl7 dot ims dot intel dot com> <CAMe9rOoQ+TiWhZEeMS0_9KZ_+pti8AFDRD56Jv7wj5PUqvdr3w at mail dot gmail dot com> <20141204115733 dot GA1923 at tucnak dot redhat dot com> <CAMe9rOpFcFkAkxzeZub2bqM8pzRf3D4-z7jcjpaJX+-i=p-HnA at mail dot gmail dot com> <20141204120426 dot GB1923 at tucnak dot redhat dot com>
On Thu, Dec 4, 2014 at 1:04 PM, Jakub Jelinek <jakub@redhat.com> wrote:
> On Thu, Dec 04, 2014 at 04:00:27AM -0800, H.J. Lu wrote:
>> >> Can you add a few testcases?
>> >
>> > Isn't it already covered by gcc.dg/torture/vshuf* ?
>> >
>>
>> I didn't see them fail on my machines today.
>
> Those are executable testcases, those better should not fail.
> The patch just improved code generation and the testcases test
> if the improved code generation works well.
> Did you mean some scan-assembler test that verifies the better code
> generation? Guess it is possible, though fragile.
I think that existing executable testcases adequately cover the
functionality of the patch.
The patch is OK.
Thanks,
Uros.