This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [arm][patch] fix arm_neon_ok check on !arm_arch7
- From: Andrew Stubbs <andrew_stubbs at mentor dot com>
- To: <ramrad01 at arm dot com>, Kyrill Tkachov <kyrylo dot tkachov at arm dot com>
- Cc: James Greenhalgh <james dot greenhalgh at arm dot com>, Andrew Stubbs <ams at codesourcery dot com>, Richard Earnshaw <Richard dot Earnshaw at arm dot com>, "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>
- Date: Wed, 3 Dec 2014 15:03:34 +0000
- Subject: Re: [arm][patch] fix arm_neon_ok check on !arm_arch7
- Authentication-results: sourceware.org; auth=none
- References: <5414B99D dot 3020202 at codesourcery dot com> <5416B580 dot 9070208 at arm dot com> <5416C5C3 dot 8070603 at codesourcery dot com> <20140923082716 dot GA28745 at arm dot com> <547DC637 dot 5060906 at arm dot com> <CAJA7tRZ_X1zKCW7LRCbnWhxfG-PbKTWpp6qmq1kcHcKiTRzstg at mail dot gmail dot com>
On 02/12/14 21:45, Ramana Radhakrishnan wrote:
I've spent some time this evening pondering over your patch. Firstly
it appears that the current behaviour is going to cause more breakage
than originally expected. If this is to go in we'd have a number of
users having to add -mfloat-abi=soft to the command line option to
ensure that -march=armv5te works just fine on the files where
march=armv5te in the first places.
Agreed. I've just reverted the patch.
I'm not sure that the original patch is enough.
The tools have always allowed us to drop down the arch to
march=armv5te along with using -mfpu=neon. We are now changing command
line behaviour, so an inform in terms of diagnostics to the user would
be useful as it states that we don't really have mfpu=neon generating
neon code any more because of this particular case. If we are to do
this then the original patch is probably not enough as it then doesn't
handle the case of TARGET_VFP3 / TARGET_VFP5 / TARGET_NEON_FP16 /
TARGET_FP16 / TARGET_FPU_ARMV8 etc. etc. etc.
I'll take a look at those shortly.
Andrew