This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [Ping]Re: [PR63762][4.9] Backport the patch which fixes "GCC generates UNPREDICTABLE STR with Rn = Rt for arm"

From: Vladimir Makarov <vmakarov at redhat dot com>
To: Renlin Li <renlin dot li at arm dot com>, "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>
Cc: "H.J. Lu" <hjl dot tools at gmail dot com>, Ramana Radhakrishnan <Ramana dot Radhakrishnan at arm dot com>
Date: Tue, 02 Dec 2014 23:46:08 -0500
Subject: Re: [Ping]Re: [PR63762][4.9] Backport the patch which fixes "GCC generates UNPREDICTABLE STR with Rn = Rt for arm"
Authentication-results: sourceware.org; auth=none
References: <546E141C dot 9070906 at arm dot com> <5475C29E dot 9090209 at arm dot com> <CAMe9rOpo=3j9gPqh7pxceA54bPm6kCUg3Y8u6WNrM90nAd1T_w at mail dot gmail dot com> <54761769 dot 3040200 at arm dot com> <CAMe9rOqAgu=ffQhgZvbOy5_qEWNRrY9iu=5Jf8tUNrscufV6pA at mail dot gmail dot com> <54774402 dot 10403 at arm dot com> <CAMe9rOqYQQ+GP-VzLwG-qNdF5a4+eBs=4A846_Go4Srpj-9JAg at mail dot gmail dot com> <54775386 dot 1060409 at arm dot com> <CAMe9rOp_n5sFz3hdc_CUtLqkW2tBYdSKBi488BUnJn-Gu8iktw at mail dot gmail dot com> <547CA43A dot 2080005 at arm dot com>

On 2014-12-01 12:24 PM, Renlin Li wrote:

On 01/12/14 15:58, H.J. Lu wrote:

On Thu, Nov 27, 2014 at 8:38 AM, Renlin Li <renlin.li@arm.com> wrote:

On 27/11/14 15:37, H.J. Lu wrote:

On Thu, Nov 27, 2014 at 7:32 AM, Renlin Li <renlin.li@arm.com> wrote:

On 26/11/14 18:12, H.J. Lu wrote:

On Wed, Nov 26, 2014 at 10:09 AM, Renlin Li <renlin.li@arm.com>
wrote:

On 26/11/14 12:16, H.J. Lu wrote:

On Wed, Nov 26, 2014 at 4:07 AM, Renlin Li <renlin.li@arm.com>
wrote:

On 20/11/14 16:17, Renlin Li wrote:

Hi all,

This is a backport for gcc-4_9-branch of the patch "[PR63762]GCC
generates
UNPREDICTABLE STR with Rn = Rt for arm" posted in:
https://gcc.gnu.org/ml/gcc-patches/2014-11/msg02253.html

arm-none-eabi has been test on the model, no new issues.
bootstrapping
and
regression tested on x86, no new issues.

Is it Okay for gcc-4_9-branch?

gcc/ChangeLog:

2014-11-20  Renlin Li  <Renlin.Li@arm.com>

        PR middle-end/63762
        * ira.c (ira): Update preferred class.

gcc/testsuite/ChangeLog:

2014-11-20  Renlin Li  <Renlin.Li@arm.com>

        PR middle-end/63762
        * gcc.dg/pr63762.c: New.

Ping for it.

Please verify if it is the real fix for

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63661

If yes, please add a testcase for PR 63661 and mention it in
your ChangeLog entry.

Thanks.

Hi H.J.

Yes, I have verified that, this patch additionally fixes PR 63661.

I observed the same behaviour as I saw on arm backend. It will be
great
if
you can double check they are caused by exactly the same reason.

I will ask our people to take a look.

A new testcase has been added, ChangeLog has been updated to reflect
the
change. Updated patch has bee attached.
Okay for gcc-4_9-branch?

Regards,
Renlin Li


gcc/ChangeLog:

2014-11-26  Renlin Li  <Renlin.Li@arm.com>

       PR middle-end/63762
       PR middle-end/63661
       * ira.c (ira): Update preferred class.

gcc/testsuite/ChangeLog:

2014-11-26  Renlin Li  <Renlin.Li@arm.com>

       PR middle-end/63661
       PR middle-end/63762
       * testsuite/gcc.dg/pr63661.c: New.
       * testsuite/gcc.dg/pr63762.c: New.

pr63661.c should be moved to gcc.target/i386 and run it
on PIC target.

Thanks.

Hi H.J.

The patch has been adjusted according to your suggestion.


gcc/ChangeLog:

2014-11-27  Renlin Li  <Renlin.Li@arm.com>

      PR middle-end/63762
      PR target/63661
      * ira.c (ira): Update preferred class.

gcc/testsuite/ChangeLog:

2014-11-27  Renlin Li  <Renlin.Li@arm.com>

      PR middle-end/63762
      PR target/63661
      * testsuite/gcc.dg/pr63762.c: New.
      * testsuite/gcc.target/i386/pr63661.c: New.

          ^^^^^^^^^^^  No testsuite/


Hi H.J.

gcc.target/i386/pr63661.c should be checked into trunk first.

A separate patch is sent to mailing list for this.


ChangeLog has been corrected.

Regards,
Renlin Li

gcc/ChangeLog:

2014-11-27  Renlin Li  <Renlin.Li@arm.com>

     PR middle-end/63762
     PR target/63661
     * ira.c (ira): Update preferred class.

gcc/testsuite/ChangeLog:

2014-11-27  Renlin Li  <Renlin.Li@arm.com>

     PR middle-end/63762
     PR target/63661
     * gcc.dg/pr63762.c: New.
     * gcc.target/i386/pr63661.c: New.

You need to update gcc.target/i386/pr63661.c from trunk.


Update the test case for pr63661 from trunk.

Okay for gcc-4_9-branch?


Yes. Thanks for working on this, Renlin.

References:
- Re: [Ping]Re: [PR63762][4.9] Backport the patch which fixes "GCC generates UNPREDICTABLE STR with Rn = Rt for arm"
  - From: H.J. Lu
- Re: [Ping]Re: [PR63762][4.9] Backport the patch which fixes "GCC generates UNPREDICTABLE STR with Rn = Rt for arm"
  - From: Renlin Li

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]