This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH 5/6] combine: handle REG_UNUSED in reg_dead_at_p (PR59278)

From: Jeff Law <law at redhat dot com>
To: Oleg Endo <oleg dot endo at t-online dot de>
Cc: Segher Boessenkool <segher at kernel dot crashing dot org>, gcc-patches at gcc dot gnu dot org
Date: Tue, 02 Dec 2014 13:15:56 -0700
Subject: Re: [PATCH 5/6] combine: handle REG_UNUSED in reg_dead_at_p (PR59278)
Authentication-results: sourceware.org; auth=none
References: <cover dot 1417135737 dot git dot segher at kernel dot crashing dot org> <2722d25dd8dd4c358b092a67c28042d3e9d93af5 dot 1417135738 dot git dot segher at kernel dot crashing dot org> <547CA788 dot 10903 at redhat dot com> <1417476652 dot 3387 dot 121 dot camel at yam-132-YW-E178-FTW>

On 12/01/14 16:30, Oleg Endo wrote:

On Mon, 2014-12-01 at 10:38 -0700, Jeff Law wrote:

On 11/27/14 18:44, Segher Boessenkool wrote:

Currently reg_dead_at_p returns 0 for registers that are set but never
used.  This patch repairs that oversight.  This fixes PR59278.


2014-11-27  Segher Boessenkool  <segher@kernel.crashing.org>

gcc/
	PR rtl-optimization/59278
	combine (reg_dead_at_p): Consider REG_UNUSED notes.

OK with a testcase.  ISTM you can just create an SH specific testcase
from the code in the BZ.  Pre-approved with suitable testcase.

jeff


Attached is the SH test case for the PR, which passes with the combine
patch applied for make -k check-gcc RUNTESTFLAGS="sh.exp=pr59278.c
--target_board=sh-sim\{-m4/-ml,-m4/-mb,-m2a/-mb,-m2/-mb}"

Cheers,
Oleg

testsuite/ChangeLog:
	* gcc.target/sh/pr59278.c: New.

OK, please commit after Segher or together as a unified patch+testcase.

jeff

References:
- Re: [PATCH 5/6] combine: handle REG_UNUSED in reg_dead_at_p (PR59278)
  - From: Jeff Law
- Re: [PATCH 5/6] combine: handle REG_UNUSED in reg_dead_at_p (PR59278)
  - From: Oleg Endo

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]