This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH x86] Update options for avx512 testsuite.
- From: "H.J. Lu" <hjl dot tools at gmail dot com>
- To: Ilya Tocar <tocarip dot intel at gmail dot com>
- Cc: Uros Bizjak <ubizjak at gmail dot com>, GCC Patches <gcc-patches at gcc dot gnu dot org>
- Date: Mon, 1 Dec 2014 08:38:28 -0800
- Subject: Re: [PATCH x86] Update options for avx512 testsuite.
- Authentication-results: sourceware.org; auth=none
- References: <20141128150848 dot GA74953 at msticlxl7 dot ims dot intel dot com> <CAFULd4aC-tdygk1Nuh=DyKjbV6kkA8_LreUwubJoWf+89uNF2g at mail dot gmail dot com> <CAMe9rOrCpw3pE0WHyjD33OM2TQ6BOQXqOhhtHwhJJteF1p2BJg at mail dot gmail dot com> <CAMe9rOrAtKfdDsWUL=QeX=H=cs5hw20AmNfSu7uNtmwz7yTopw at mail dot gmail dot com> <20141201163503 dot GA128172 at msticlxl7 dot ims dot intel dot com>
On Mon, Dec 1, 2014 at 8:35 AM, Ilya Tocar <tocarip.intel@gmail.com> wrote:
>> > I saw
>> >
>> > FAIL: gcc.dg/vect/costmodel/i386/costmodel-fast-math-vect-pr29925.c
>> > scan-tree-dump-times vect "vectorized 1 loops" 1
>> > FAIL: gcc.dg/vect/costmodel/x86_64/costmodel-fast-math-vect-pr29925.c
>> > scan-tree-dump-times vect "vectorized 1 loops" 1
>> > FAIL: gcc.target/i386/avx256-unaligned-store-2.c scan-assembler
>> > vmovups.*\\\\*movv16qi_internal/3
>> > FAIL: gcc.target/i386/avx512ifma-vpmaddhuq-2.c (test for excess errors)
>> > UNRESOLVED: gcc.target/i386/avx512ifma-vpmaddhuq-2.c compilation
>> > failed to produce executable
>> > FAIL: gcc.target/i386/avx512ifma-vpmaddluq-2.c (test for excess errors)
>> > UNRESOLVED: gcc.target/i386/avx512ifma-vpmaddluq-2.c compilation
>> > failed to produce executable
>> > FAIL: gcc.target/i386/avx512vbmi-vpermb-2.c (test for excess errors)
>> > UNRESOLVED: gcc.target/i386/avx512vbmi-vpermb-2.c compilation failed
>> > to produce executable
>> > FAIL: gcc.target/i386/avx512vbmi-vpermi2b-2.c (test for excess errors)
>> > UNRESOLVED: gcc.target/i386/avx512vbmi-vpermi2b-2.c compilation failed
>> > to produce executable
>> > FAIL: gcc.target/i386/avx512vbmi-vpermt2b-2.c (test for excess errors)
>> > UNRESOLVED: gcc.target/i386/avx512vbmi-vpermt2b-2.c compilation failed
>> > to produce executable
>> > FAIL: gcc.target/i386/avx512vbmi-vpmultishiftqb-2.c (test for excess errors)
>> > UNRESOLVED: gcc.target/i386/avx512vbmi-vpmultishiftqb-2.c compilation
>> > failed to produce executable
>> >
>> > on x86:
>> >
>> > https://gcc.gnu.org/ml/gcc-testresults/2014-12/msg00030.html
>> >
>> >
>>
>> I took a look at one of them:
>>
>> diff --git a/gcc/testsuite/gcc.target/i386/avx512vbmi-vpmultishiftqb-2.c
>> b/gcc/testsuite/gcc.target/i386/avx512vbmi-vpmultishiftqb-2.c
>> index 936d938..861dce2 100644
>> --- a/gcc/testsuite/gcc.target/i386/avx512vbmi-vpmultishiftqb-2.c
>> +++ b/gcc/testsuite/gcc.target/i386/avx512vbmi-vpmultishiftqb-2.c
>> @@ -1,5 +1,5 @@
>> /* { dg-do run } */
>> -/* { dg-options "-O2 -mavx512vbmi -DAVX512VBMI" } */
>> +/* { dg-options "-O2 -mavx512vbmi" } */
>> /* { dg-require-effective-target avx512vbmi } */
>>
>> #include "avx512f-helper.h"
>>
>> There is no "#define AVX512VBM" added.
>>
>>
> My bad,
>
> Patch below fixed avx512* tests.
> No idea about cost-model ones.
>
> ---
> gcc/testsuite/gcc.target/i386/avx512ifma-vpmaddhuq-2.c | 2 ++
> gcc/testsuite/gcc.target/i386/avx512ifma-vpmaddluq-2.c | 2 ++
> gcc/testsuite/gcc.target/i386/avx512vbmi-vpermb-2.c | 2 ++
> gcc/testsuite/gcc.target/i386/avx512vbmi-vpermi2b-2.c | 2 ++
> gcc/testsuite/gcc.target/i386/avx512vbmi-vpermt2b-2.c | 2 ++
> gcc/testsuite/gcc.target/i386/avx512vbmi-vpmultishiftqb-2.c | 2 ++
> 6 files changed, 12 insertions(+)
This counts as obvious. Please check it in with proper ChangeLog
entries.
--
H.J.