This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH][AArch64]Tidy up aarch64_simd_expand_args
- From: Marcus Shawcroft <marcus dot shawcroft at gmail dot com>
- To: Alan Lawrence <alan dot lawrence at arm dot com>
- Cc: "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>
- Date: Fri, 21 Nov 2014 16:12:49 +0000
- Subject: Re: [PATCH][AArch64]Tidy up aarch64_simd_expand_args
- Authentication-results: sourceware.org; auth=none
- References: <546A28A0 dot 6090808 at arm dot com>
On 17 November 2014 16:56, Alan Lawrence <alan.lawrence@arm.com> wrote:
> This is a pure tidyup, no new functionality. Changes are
> (1) Use op[0] to store the result operand, rather than a separate variable,
> thus combining the two large switch statements into one;
> (2) The 'arg' and 'mode' arrays were (almost-)only ever used to store data
> *within* each iteration, so turn them into scalar variables.
> (3) Use 'opc' rather than 'argc' as it indexes operands.
>
> Cross-tested check-gcc on aarch64-none-elf.
>
> gcc/ChangeLog:
> * config/aarch64/aarch64-builtins.c (aarch64_simd_expand_args):
> Refactor by combining switch statements and make arrays into
> scalars.
OK /Marcus