This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [Patch] PR 61692 - Fix for inline asm ICE
- From: David Wohlferd <dw at LimeGreenSocks dot com>
- To: law at redhat dot com
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Sat, 15 Nov 2014 19:59:52 -0800
- Subject: Re: [Patch] PR 61692 - Fix for inline asm ICE
- Authentication-results: sourceware.org; auth=none
- References: <53D4A9A2 dot 2050402 at LimeGreenSocks dot com> <53D6A79E dot 8060300 at redhat dot com> <53D6D107 dot 3030404 at LimeGreenSocks dot com> <53D9CCE4 dot 8010305 at redhat dot com> <53DB4AB5 dot 4010709 at LimeGreenSocks dot com> <53DBDC86 dot 7060809 at redhat dot com> <54154E0D dot 30806 at LimeGreenSocks dot com> <54175F6A dot 70609 at redhat dot com>
On 9/15/2014 2:51 PM, Jeff Law wrote:
Let's go with your original inputs + outputs + labels change and punt
the clobbers stuff for now.
jeff
I have also added the test code you requested.
I have a release on file with the FSF, but don't have SVN write access.
Problem:
extract_insn() in recog.c will ICE if (noperands > MAX_RECOG_OPERANDS).
Normally this isn't a problem since expand_asm_operands() in cfgexpand.c
catches and reports a proper error for this condition. However,
expand_asm_operands() only checks (ninputs + noutputs) instead of
(ninputs + noutputs + nlabels), so you can get the ICE when using "asm
goto."
ChangeLog:
2014-11-15 David Wohlferd <dw@LimeGreenSocks.com>
PR target/61692
* cfgexpand.c (expand_asm_operands): Count all inline asm params.
* testsuite/gcc.dg/pr61692.c: New test.
dw
Index: gcc/cfgexpand.c
===================================================================
--- gcc/cfgexpand.c (revision 217623)
+++ gcc/cfgexpand.c (working copy)
@@ -2589,7 +2589,7 @@
}
ninputs += ninout;
- if (ninputs + noutputs > MAX_RECOG_OPERANDS)
+ if (ninputs + noutputs + nlabels > MAX_RECOG_OPERANDS)
{
error ("more than %d operands in %<asm%>", MAX_RECOG_OPERANDS);
return;
Index: gcc/testsuite/gcc.dg/pr61692.c
===================================================================
--- gcc/testsuite/gcc.dg/pr61692.c (revision 0)
+++ gcc/testsuite/gcc.dg/pr61692.c (working copy)
@@ -0,0 +1,173 @@
+/* PR 61692 */
+
+/* Check for ice when exceededing the max #
+ of parameters to inline asm. */
+
+int Labels()
+{
+ label01: label02: label03: label04: label05:
+ label06: label07: label08: label09: label10:
+ label11: label12: label13: label14: label15:
+ label16: label17: label18: label19: label20:
+ label21: label22: label23: label24: label25:
+ label26: label27: label28: label29: label30:
+ label31:
+
+ __asm__ goto ("" /* Works. */
+ : /* no outputs */
+ : /* no inputs */
+ : /* no clobbers */
+ : label01, label02, label03, label04, label05,
+ label06, label07, label08, label09, label10,
+ label11, label12, label13, label14, label15,
+ label16, label17, label18, label19, label20,
+ label21, label22, label23, label24, label25,
+ label26, label27, label28, label29, label30);
+
+ __asm__ goto ("" /* { dg-error "more than 30 operands" } */
+ : /* no outputs */
+ : /* no inputs */
+ : /* no clobbers */
+ : label01, label02, label03, label04, label05,
+ label06, label07, label08, label09, label10,
+ label11, label12, label13, label14, label15,
+ label16, label17, label18, label19, label20,
+ label21, label22, label23, label24, label25,
+ label26, label27, label28, label29, label30,
+ label31);
+
+ return 0;
+}
+
+int Labels_and_Inputs()
+{
+ int b01, b02, b03, b04, b05, b06, b07, b08, b09, b10;
+ int b11, b12, b13, b14, b15, b16, b17, b18, b19, b20;
+ int b21, b22, b23, b24, b25, b26, b27, b28, b29, b30;
+ int b31;
+
+ label01: label02: label03: label04: label05:
+ label06: label07: label08: label09: label10:
+ label11: label12: label13: label14: label15:
+ label16: label17: label18: label19: label20:
+ label21: label22: label23: label24: label25:
+ label26: label27: label28: label29: label30:
+ label31:
+
+ b01 = b02 = b03 = b04 = b05 = b06 = b07 = b08 = b09 = b10 = 0;
+ b11 = b12 = b13 = b14 = b15 = b16 = b17 = b18 = b19 = b20 = 0;
+ b21 = b22 = b23 = b24 = b25 = b26 = b27 = b28 = b29 = b30 = 0;
+ b31 = 0;
+
+ __asm__ goto ("" /* Works. */
+ : /* no outputs */
+ : "m" (b01), "m" (b02), "m" (b03), "m" (b04), "m" (b05),
+ "m" (b06), "m" (b07), "m" (b08), "m" (b09), "m" (b10),
+ "m" (b11), "m" (b12), "m" (b13), "m" (b14), "m" (b15),
+ "m" (b16), "m" (b17), "m" (b18), "m" (b19), "m" (b20),
+ "m" (b21), "m" (b22), "m" (b23), "m" (b24), "m" (b25),
+ "m" (b26), "m" (b27), "m" (b28), "m" (b29)
+ : /* no clobbers */
+ : label01);
+
+ __asm__ goto ("" /* { dg-error "more than 30 operands" } */
+ : /* no outputs */
+ : "m" (b01), "m" (b02), "m" (b03), "m" (b04), "m" (b05),
+ "m" (b06), "m" (b07), "m" (b08), "m" (b09), "m" (b10),
+ "m" (b11), "m" (b12), "m" (b13), "m" (b14), "m" (b15),
+ "m" (b16), "m" (b17), "m" (b18), "m" (b19), "m" (b20),
+ "m" (b21), "m" (b22), "m" (b23), "m" (b24), "m" (b25),
+ "m" (b26), "m" (b27), "m" (b28), "m" (b29), "m" (b30)
+ : /* no clobbers */
+ : label01);
+
+ return 0;
+}
+
+int Outputs()
+{
+ int b01, b02, b03, b04, b05, b06, b07, b08, b09, b10;
+ int b11, b12, b13, b14, b15, b16, b17, b18, b19, b20;
+ int b21, b22, b23, b24, b25, b26, b27, b28, b29, b30;
+ int b31;
+
+ /* Outputs. */
+ __asm__ volatile ("" /* Works. */
+ : "=m" (b01), "=m" (b02), "=m" (b03), "=m" (b04), "=m" (b05),
+ "=m" (b06), "=m" (b07), "=m" (b08), "=m" (b09), "=m" (b10),
+ "=m" (b11), "=m" (b12), "=m" (b13), "=m" (b14), "=m" (b15),
+ "=m" (b16), "=m" (b17), "=m" (b18), "=m" (b19), "=m" (b20),
+ "=m" (b21), "=m" (b22), "=m" (b23), "=m" (b24), "=m" (b25),
+ "=m" (b26), "=m" (b27), "=m" (b28), "=m" (b29), "=m" (b30));
+
+ __asm__ volatile ("" /* { dg-error "more than 30 operands" } */
+ : "=m" (b01), "=m" (b02), "=m" (b03), "=m" (b04), "=m" (b05),
+ "=m" (b06), "=m" (b07), "=m" (b08), "=m" (b09), "=m" (b10),
+ "=m" (b11), "=m" (b12), "=m" (b13), "=m" (b14), "=m" (b15),
+ "=m" (b16), "=m" (b17), "=m" (b18), "=m" (b19), "=m" (b20),
+ "=m" (b21), "=m" (b22), "=m" (b23), "=m" (b24), "=m" (b25),
+ "=m" (b26), "=m" (b27), "=m" (b28), "=m" (b29), "=m" (b30),
+ "=m" (b31));
+
+ return 0;
+}
+
+int Inputs()
+{
+ int b01, b02, b03, b04, b05, b06, b07, b08, b09, b10;
+ int b11, b12, b13, b14, b15, b16, b17, b18, b19, b20;
+ int b21, b22, b23, b24, b25, b26, b27, b28, b29, b30;
+ int b31;
+
+ b01 = b02 = b03 = b04 = b05 = b06 = b07 = b08 = b09 = b10 = 0;
+ b11 = b12 = b13 = b14 = b15 = b16 = b17 = b18 = b19 = b20 = 0;
+ b21 = b22 = b23 = b24 = b25 = b26 = b27 = b28 = b29 = b30 = 0;
+ b31 = 0;
+
+ __asm__ volatile ("" /* Works. */
+ : /* no outputs */
+ : "m" (b01), "m" (b02), "m" (b03), "m" (b04), "m" (b05),
+ "m" (b06), "m" (b07), "m" (b08), "m" (b09), "m" (b10),
+ "m" (b11), "m" (b12), "m" (b13), "m" (b14), "m" (b15),
+ "m" (b16), "m" (b17), "m" (b18), "m" (b19), "m" (b20),
+ "m" (b21), "m" (b22), "m" (b23), "m" (b24), "m" (b25),
+ "m" (b26), "m" (b27), "m" (b28), "m" (b29), "m" (b30));
+
+ __asm__ volatile ("" /* { dg-error "more than 30 operands" } */
+ : /* no outputs */
+ : "m" (b01), "m" (b02), "m" (b03), "m" (b04), "m" (b05),
+ "m" (b06), "m" (b07), "m" (b08), "m" (b09), "m" (b10),
+ "m" (b11), "m" (b12), "m" (b13), "m" (b14), "m" (b15),
+ "m" (b16), "m" (b17), "m" (b18), "m" (b19), "m" (b20),
+ "m" (b21), "m" (b22), "m" (b23), "m" (b24), "m" (b25),
+ "m" (b26), "m" (b27), "m" (b28), "m" (b29), "m" (b30),
+ "m" (b31));
+
+ return 0;
+}
+
+int Input_Output()
+{
+ int b01, b02, b03, b04, b05, b06, b07, b08, b09, b10;
+ int b11, b12, b13, b14, b15, b16, b17, b18, b19, b20;
+ int b21, b22, b23, b24, b25, b26, b27, b28, b29, b30;
+ int b31;
+
+ b01 = b02 = b03 = b04 = b05 = b06 = b07 = b08 = b09 = b10 = 0;
+ b11 = b12 = b13 = b14 = b15 = b16 = b17 = b18 = b19 = b20 = 0;
+ b21 = b22 = b23 = b24 = b25 = b26 = b27 = b28 = b29 = b30 = 0;
+ b31 = 0;
+
+ __asm__ volatile ("" /* Works. */
+ : "+m" (b01), "+m" (b02), "+m" (b03), "+m" (b04), "+m" (b05),
+ "+m" (b06), "+m" (b07), "+m" (b08), "+m" (b09), "+m" (b10),
+ "+m" (b11), "+m" (b12), "+m" (b13), "+m" (b14), "+m" (b15));
+
+ __asm__ volatile ("" /* { dg-error "more than 30 operands" } */
+ : "+m" (b01), "+m" (b02), "+m" (b03), "+m" (b04), "+m" (b05),
+ "+m" (b06), "+m" (b07), "+m" (b08), "+m" (b09), "+m" (b10),
+ "+m" (b11), "+m" (b12), "+m" (b13), "+m" (b14), "+m" (b15),
+ "+m" (b16));
+
+ return 0;
+}