Re: [C++ Patch] Add maybe_constant_folded_value

[Paolo Carlini <paolo dot carlini at oracle dot com>]

Hi,

On 11/13/2014 05:42 PM, Jason Merrill wrote:
> On 11/13/2014 11:10 AM, Jason Merrill wrote:
> > On 11/13/2014 05:47 AM, Paolo Carlini wrote:
> > > shall we do something like the below?
> >
> > Something similar, yes.  Though it would also be nice to avoid the
> > redundant checking in the two functions: we only want to do constexpr
> > folding if we did the tsubst.
> >
> > Kai is working on folding changes, so I think let's let him weigh in on
> > how this will interact with his work.
>
> Kai says this is fine with him.  I think I'd like to rename the 
> current fold_non_dependent_expr* to instantiate_non_dependent_expr* 
> and make your new function fold_non_dependent_expr, since it's the one 
> that's doing full constant folding.
Good. Then I'm finishing sanity checking the below.

While we are at it, can you double check that in end_maybe_infinite_loop 
we really want the non-sfinae version (which in principle can emit hard 
errors): the inconsistency with begin_maybe_infinite_loop seems weird to 
me...

Thanks!
Paolo.

////////////////////

Attachment: CL2
Description: Text document

Attachment: patchlet2
Description: Text document