This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [patch, v2] Fix libtool.m4 for Darwin >= 10.10
- From: Jack Howarth <howarth dot at dot gcc at gmail dot com>
- To: Mike Stump <mikestump at comcast dot net>
- Cc: FX <fxcoudert at gmail dot com>, GCC Patches <gcc-patches at gcc dot gnu dot org>
- Date: Tue, 11 Nov 2014 14:48:38 -0500
- Subject: Re: [patch, v2] Fix libtool.m4 for Darwin >= 10.10
- Authentication-results: sourceware.org; auth=none
- References: <D7EC6C1D-8992-48B6-9697-E0BC6EFEEF02 at gmail dot com> <D48BBC64-5DC4-457B-92FD-CA9E2DF1645C at gmail dot com> <E2F7623B-4160-4EB4-81B6-EE5191928901 at comcast dot net>
Mike,
The only problem with this fix for the broken libtool.m4 is that
it will require constant tending as other patches regenerate these
various configure files. For example,
https://gcc.gnu.org/ml/gcc-cvs/2014-11/msg00379.html which was just
committed would have removed the proposed change had it been committed
earlier today.
Jack
On Tue, Nov 11, 2014 at 2:38 PM, Mike Stump <mikestump@comcast.net> wrote:
> On Nov 11, 2014, at 11:06 AM, FX <fxcoudert@gmail.com> wrote:
>> Hereâs v2 of the patch
>
>> OK to commit?
>
> Ok with comments:
>
> libvtv:
>
> libvtv/
> 2014-11-11 Francois-Xavier Coudert <fxcoudert@gcc.gnu.org>
>
> PR target/63610
> * configure:
>
> Missing Regenerate.
>
>> OK to commit?
>
> Ok.
>
>> This touches so many area it probably needs a build maintainer or global maintainer to approve it.
>
> Only darwin is affected, and unlikely anyone else cares much about it. Iâm fine approving it. Arguably, imports from libtool upstream are trivial anyway.
>
> If someone else wants to import all of libtool, we welcome their contribution.