This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [patch] OpenACC fortran tests
- From: Tobias Burnus <burnus at net-b dot de>
- To: Cesar Philippidis <cesar at codesourcery dot com>, "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>, fortran at gcc dot gnu dot org
- Date: Tue, 11 Nov 2014 07:51:18 +0100
- Subject: Re: [patch] OpenACC fortran tests
- Authentication-results: sourceware.org; auth=none
- References: <545BF7F6 dot 9080807 at codesourcery dot com>
Cesar Philippidis wrote:
This patch contains compile-time tests for OpenACC in gfortran. Is this
patch OK for mainline trunk after the OpenACC fortran front end changes
make their way in?
I browsed the test cases â and they look okay. I didn't try hard to see
whether every single one is valid nor whether some are missing, but my
hope is that most of those issues were caught during the branch review.
NOTE: There is one
+! FIXME: This causes an ICE in the gimplifier.
and for nonexpanding a builtin:
+! TODO: not working.
and
+! TODO: nested kernels are allowed in 2.0
and additionally - related to OpenACC's cache
+! TODO: These cases must fail
Unless the ICE is fixed until the commit, I would suggest to fill a PR
for it to make sure it won't be forgotten. (One should probably add an
"openacc" keyword.) And "cache" and nonnested kernels look like items
for the release notes.
Thanks for the test cases to everyone involved!
Tobias