This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: RFC: Update ISL under gcc/infrastructure/ ? // Remove CLooG?

From: Tobias Grosser <tobias at grosser dot es>
To: Roman Gareev <gareevroman at gmail dot com>
Cc: tobias dot burnus at physik dot fu-berlin dot de, Richard Biener <richard dot guenther at gmail dot com>, Albert Cohen <albert dot cohen at inria dot fr>, skimo at kotnet dot org, Mircea Namolaru <mircea dot namolaru at inria dot fr>, gcc-patches at gcc dot gnu dot org
Date: Mon, 10 Nov 2014 12:59:54 +0100
Subject: Re: RFC: Update ISL under gcc/infrastructure/ ? // Remove CLooG?
Authentication-results: sourceware.org; auth=none
References: <20141104151755 dot GA13200 at physik dot fu-berlin dot de> <545AB53E dot 5080808 at grosser dot es> <CABGF_gfmcazQLXPxZ4ET3P0VCNPYxYazJGWDY3GsGzFaj1ueGA at mail dot gmail dot com> <545B1D00 dot 6060605 at grosser dot es> <CABGF_gcx6nmZw87wfERJt+2sdYc4MDTkZVaSaFSYjPqLH4N5yw at mail dot gmail dot com> <545BD2F8 dot 1050104 at grosser dot es> <CABGF_gdXWbq8eqxYTOfuuJ3VKGpLfo_v75sT6SNzAV=ThWJi-g at mail dot gmail dot com> <545E768A dot 9000101 at grosser dot es> <CABGF_gfK1kYU-ODxMb0YGZgrv9RpTcC=0wfBC8GN5aLJOQJr6Q at mail dot gmail dot com> <545FA53F dot 9080304 at grosser dot es> <CABGF_gebp5ECWJ4G=-=2tXN88P+Hpd9tsVYpHofwu=3LRwK4mg at mail dot gmail dot com>

On 10.11.2014 10:03, Roman Gareev wrote:

The patch looks great. The only piece I think we missed is the
fgraphite-code-generator flag. I would propose to remove it as well in this
commit, as it does not have any effect any more.


In this case, weâll also have to change tests which use
fgraphite-code-generator flag (isl-ast-gen-blocks-1.c,
isl-ast-gen-blocks-2.c, isl-ast-gen-blocks-3.c,
isl-ast-gen-blocks-4.c, isl-ast-gen-if-1.c, isl-ast-gen-if-2.c,
isl-ast-gen-single-loop-1.c, isl-ast-gen-single-loop-2.c,
isl-ast-gen-user-1.c, isl-codegen-loop-dumping.c). Maybe we should do
this in the next patch?


Sure. We should drop the flag in these test cases.

This seems to make sense, as they now test something different and theflag removal would reflect this.


I personally would include this in the same patch. Would this be difficult?

Cheers,
Tobias

Follow-Ups:
- Re: RFC: Update ISL under gcc/infrastructure/ ? // Remove CLooG?
  - From: Roman Gareev

References:
- Re: RFC: Update ISL under gcc/infrastructure/ ? // Remove CLooG?
  - From: Roman Gareev
- Re: RFC: Update ISL under gcc/infrastructure/ ? // Remove CLooG?
  - From: Tobias Grosser
- Re: RFC: Update ISL under gcc/infrastructure/ ? // Remove CLooG?
  - From: Roman Gareev

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]