This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH 10/27] New file: gcc/jit/libgccjit.c

From: Jeff Law <law at redhat dot com>
To: David Malcolm <dmalcolm at redhat dot com>
Cc: gcc-patches at gcc dot gnu dot org, jit at gcc dot gnu dot org
Date: Fri, 07 Nov 2014 12:47:41 -0700
Subject: Re: [PATCH 10/27] New file: gcc/jit/libgccjit.c
Authentication-results: sourceware.org; auth=none
References: <1414774977-25605-1-git-send-email-dmalcolm at redhat dot com> <1414774977-25605-11-git-send-email-dmalcolm at redhat dot com> <5457E65B dot 9050204 at redhat dot com> <1415120262 dot 29411 dot 125 dot camel at surprise> <545947AE dot 2070606 at redhat dot com> <1415216074 dot 29411 dot 138 dot camel at surprise>

On 11/05/14 12:34, David Malcolm wrote:


I've added comments throughout the file.

I didn't bother adding __attribute__((cold)), instead simply dropping
that "TODO".

Fine.


Attached is the current state of the file gcc/jit/libgccjit.c (on the
branch) for review.

OK for trunk? (conditional on all the rest being approved, and usual
bootstrap&regrtesting; I've merely verified a non-bootstrap compile and
successful make check-jit so far).

There were a few other changes relative to what you've approved, which
I'll post for review shortly.

Dave


libgccjit.c


/* Implementation of the C API; all wrappers into the internal C++ API
    Copyright (C) 2013-2014 Free Software Foundation, Inc.
    Contributed by David Malcolm<dmalcolm@redhat.com>.

This is fine. With the comments, it became a lot clearer this was justthe error checking wrappers and not a whole lot else.

The one thing this does make me wonder is should we add something aboutthe error checking may change in significant ways from one release tothe next, much like the ABI/API.

This seems important as the error checking in many ways specifies thelanguage for the JIT and I suspect we haven't got all the corner casessorted out yet (and probably can't until this gets into wider distribution).


jeff

Follow-Ups:
- Re: [PATCH 10/27] New file: gcc/jit/libgccjit.c
  - From: David Malcolm

References:
- Re: [PATCH 10/27] New file: gcc/jit/libgccjit.c
  - From: Jeff Law
- Re: [PATCH 10/27] New file: gcc/jit/libgccjit.c
  - From: David Malcolm
- Re: [PATCH 10/27] New file: gcc/jit/libgccjit.c
  - From: Jeff Law
- Re: [PATCH 10/27] New file: gcc/jit/libgccjit.c
  - From: David Malcolm

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]