Re: [PATCH] config-list.mk: Build Go only for supported targets (was: Patch RFA: Top-level configure patch: disable go on systems where it doesn't work)

[Jan-Benedict Glaw <jbglaw at lug-owl dot de>]

On Thu, 2014-10-30 08:08:51 -0700, Ian Taylor <iant@golang.org> wrote:
> On Thu, Oct 30, 2014 at 6:19 AM, Jan-Benedict Glaw <jbglaw@lug-owl.de> wrote:
> >
> > This updates contrib/config-list.mk to build Go for all but
> > known-non-working targets. A comment to configure{.ac,} is also added.
> 
> > diff --git a/contrib/config-list.mk b/contrib/config-list.mk
> > index 94884d9..16900e1 100644
> > --- a/contrib/config-list.mk
> > +++ b/contrib/config-list.mk
> > @@ -95,11 +95,24 @@ make-log-dir: ../gcc/MAINTAINERS
> >
> >  $(LIST): make-log-dir
> >         -mkdir $@
> > -       (cd $@ && \
> > -       ../../gcc/configure \
> > -       --target=$(subst SCRIPTS,`pwd`/../scripts/,$(subst OPT,$(empty) -,$@)) \
> > -       --enable-werror-always ${host_options} --enable-languages=all,ada,go) \
> > -       > log/$@-config.out 2>&1
> > +       (                                                                                       \
> > +               cd $@ &&                                                                        \
> > +               echo $@ &&                                                                      \
> > +               TGT=`echo $@ | sed -e 's/^\(.*\)OPT.*$$/\1/'` &&                                \
> > +               TGT=`../../gcc/config.sub $$TGT` &&                                             \
> 
> This isn't necessary.  The OPT bits will be matched by the * at the
> end of the cases anyhow.  You can just write
>                  case $@ in
> 
> This is OK with that change.

Not exactly: My intention was to keep the triplet matches as they show
up in configure.ac .  However, the target list in config-list.mk uses
(almost exclusively) shorthands for all the targets, so these need to
be expand (--> config.sub); that however won't really fly with the
OPTs in there.

MfG, JBG

-- 
      Jan-Benedict Glaw      jbglaw@lug-owl.de              +49-172-7608481
Signature of:             God put me on earth to accomplish a certain number of
the second  :            things. Right now I am so far behind I will never die.

Attachment: signature.asc
Description: Digital signature