This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [Ping] [PATCH, 4/10] expand ccmp
- From: Richard Henderson <rth at redhat dot com>
- To: Zhenqiang Chen <zhenqiang dot chen at arm dot com>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Thu, 30 Oct 2014 08:58:06 -0700
- Subject: Re: [Ping] [PATCH, 4/10] expand ccmp
- Authentication-results: sourceware.org; auth=none
- References: <000901cfd6f9$cb591f10$620b5d30$ at arm dot com> <000901cff363$653c5b80$2fb51280$ at arm dot com>
On 10/29/2014 03:30 AM, Zhenqiang Chen wrote:
> +
> +bool
> +ccmp_insn_p (rtx object)
> +{
> + rtx x = PATTERN (object);
> + if (targetm.gen_ccmp_first
> + && GET_CODE (x) == SET
> + && GET_CODE (XEXP (x, 1)) == COMPARE
> + && (GET_CODE (XEXP (XEXP (x, 1), 0)) == IOR
> + || GET_CODE (XEXP (XEXP (x, 1), 0)) == AND))
> + return true;
> + return false;
> +}
> +
With the ifcvt changes I requested, I believe this is now unused.
> +}
> +rtx
> +expand_ccmp_expr (gimple g)
Watch your spacing. And you're missing the comment before the function.
Otherwise ok.
r~