This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH][ARM] revert changes on check_effective_target_arm_*_ok
- From: Ramana Radhakrishnan <ramana dot gcc at googlemail dot com>
- To: Jiong Wang <jiong dot wang at arm dot com>
- Cc: "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>
- Date: Fri, 24 Oct 2014 12:58:52 +0100
- Subject: Re: [PATCH][ARM] revert changes on check_effective_target_arm_*_ok
- Authentication-results: sourceware.org; auth=none
- References: <544A3C3D dot 5070308 at arm dot com>
- Reply-to: ramrad01 at arm dot com
On Fri, Oct 24, 2014 at 12:47 PM, Jiong Wang <jiong.wang@arm.com> wrote:
> we should not add explicit declaration there.
>
> arm_neon.h contains those prototype already. they will be available if the
> compiler configuration is with related builtin predefine, for example
> __ARM_FEATURE_CRYPTO.
>
> so, actually, if there is any warning when compile these test programs, they
> are expected,
> and we rely on these warnings to check whether certain features are
> available.
>
> previously, I only verified on arm-none-linux-gnueabi cross check, so have
> not exposed
> these regressions.
I had also missed the vaes and vfma turning on by default by this
change. This is OK.
ramana
>
> no verified on arm-none-linux-gnueabihf, regression gone away on arm
> directory.
>
> make check RUNTESTFLAGS="aapcs.exp neon.exp acle.exp simd.exp arm.exp"
>
> ok for trunk?
>
> gcc/testsuite/
>
> * lib/target-supports.exp
> (check_effective_target_arm_crypto_ok_nocache): Remove declaration
> for
> vaeseq_u8.
> (check_effective_target_arm_neon_fp16_ok_nocache): Remove
> declaration for
> vcvt_f16_f32.
> (check_effective_target_arm_neonv2_ok_nocache): Remove declaration
> for
> vfma_f32.