This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Fix PR preprocessor/42014
- From: "Joseph S. Myers" <joseph at codesourcery dot com>
- To: Krzesimir Nowak <qdlacz at gmail dot com>
- Cc: <gcc-patches at gcc dot gnu dot org>
- Date: Sun, 19 Oct 2014 16:14:24 +0000
- Subject: Re: [PATCH] Fix PR preprocessor/42014
- Authentication-results: sourceware.org; auth=none
- References: <1413666451-15144-1-git-send-email-qdlacz at gmail dot com> <1413666451-15144-2-git-send-email-qdlacz at gmail dot com>
On Sat, 18 Oct 2014, Krzesimir Nowak wrote:
> + pp_verbatim (context->printer,
> + "%s from %r%s:%d%R", prefix, "locus",
> + diagnostic_report_from (context, map, "In file included");
We don't want to split up diagnostic text like that, because for
translation it may be necessary to translate the whole "In file included
from" text together rather than expecting two fragments to go together in
the same way they do in English. Now, right now this message isn't marked
for translation anyway (an independent bug there's no need for you to
fix), but still as a design principle things should be structured to avoid
splitting up English fragments like that.
--
Joseph S. Myers
joseph@codesourcery.com