This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH 0/17] KASan 4.9 backport
- From: Yury Gribov <y dot gribov at samsung dot com>
- To: Jakub Jelinek <jakub at redhat dot com>
- Cc: GCC Patches <gcc-patches at gcc dot gnu dot org>, Dmitry Vyukov <dvyukov at google dot com>, Konstantin Khlebnikov <k dot khlebnikov at samsung dot com>, Andrey Ryabinin <a dot ryabinin at samsung dot com>, Viacheslav Garbuzov <v dot garbuzov at samsung dot com>
- Date: Fri, 17 Oct 2014 18:15:11 +0400
- Subject: Re: [PATCH 0/17] KASan 4.9 backport
- Authentication-results: sourceware.org; auth=none
- References: <543F831B dot 4090502 at samsung dot com> <20141017121217 dot GQ10376 at tucnak dot redhat dot com> <54411D6D dot 7000009 at samsung dot com> <20141017134946 dot GX10376 at tucnak dot redhat dot com>
On 10/17/2014 05:49 PM, Jakub Jelinek wrote:
> Plus if you add misalign tests...
Sure, can do this on Monday.
> - bool use_calls = ASAN_INSTRUMENTATION_WITH_CALL_THRESHOLD < INT_MAX
- && asan_num_accesses >= ASAN_INSTRUMENTATION_WITH_CALL_THRESHOLD;
+ bool use_calls
+ = ASAN_INSTRUMENTATION_WITH_CALL_THRESHOLD < INT_MAX
+ && (flag_sanitize & SANITIZE_KERNEL_ADDRESS)
+ && asan_num_accesses >= ASAN_INSTRUMENTATION_WITH_CALL_THRESHOLD;
I agree that original code didn't quite match GNU conventions but can we
avoid reformatting it to make future backports easier? So e.g.
bool use_calls = ASAN_INSTRUMENTATION_WITH_CALL_THRESHOLD < INT_MAX
+ && (flag_sanitize & SANITIZE_KERNEL_ADDRESS)
&& asan_num_accesses >= ASAN_INSTRUMENTATION_WITH_CALL_THRESHOLD;
-Y