This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] cleanups in line-map
- From: Dodji Seketeli <dodji at redhat dot com>
- To: Manuel LÃpez-IbÃÃez <lopezibanez at gmail dot com>
- Cc: Gcc Patch List <gcc-patches at gcc dot gnu dot org>, Tom Tromey <tom at tromey dot com>
- Date: Mon, 13 Oct 2014 10:52:54 +0200
- Subject: Re: [PATCH] cleanups in line-map
- Authentication-results: sourceware.org; auth=none
- References: <CAESRpQDatbjs7nihn=hzYByAMQHzRRepiOSBLum3OAv2Qfy0DA at mail dot gmail dot com>
Manuel LÃpez-IbÃÃez <lopezibanez@gmail.com> writes:
> A few cleanups in line-map code. Bootstrapped and regression tested on
> x86_64-linux-gnu.
Thanks for doing this.
> OK?
Yes, barring this little nit:
[...]
> Index: libcpp/line-map.c
> ===================================================================
> --- libcpp/line-map.c (revision 216098)
> +++ libcpp/line-map.c (working copy)
> @@ -29,12 +29,10 @@ along with this program; see the file CO
> static void trace_include (const struct line_maps *, const struct line_map *);
> static const struct line_map * linemap_ordinary_map_lookup (struct line_maps *,
> source_location);
> static const struct line_map* linemap_macro_map_lookup (struct line_maps *,
> source_location);
> -static source_location linemap_macro_map_loc_to_def_point
> -(const struct line_map*, source_location);
This is not redundant per se, is it? It's just a forward declaration of
the function that is defined later. Just like for
linemap_macro_map_loc_unwind_toward_spelling() below. Or what am I
missing? I'd prefer to see this forward declaration stay, FWIW.
Otherwise, this cleanup patch looks good to me. If it was my call, I'd
say "OK with that change".
Thank you for tackling this.
--
Dodji