This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH i386 AVX512] [63.1/n] Add vpshufb, perm autogen (except for v64qi).
- From: Jakub Jelinek <jakub at redhat dot com>
- To: Ilya Tocar <tocarip dot intel at gmail dot com>
- Cc: Kirill Yukhin <kirill dot yukhin at gmail dot com>, Uros Bizjak <ubizjak at gmail dot com>, Richard Henderson <rth at redhat dot com>, GCC Patches <gcc-patches at gcc dot gnu dot org>
- Date: Fri, 10 Oct 2014 17:52:12 +0200
- Subject: Re: [PATCH i386 AVX512] [63.1/n] Add vpshufb, perm autogen (except for v64qi).
- Authentication-results: sourceware.org; auth=none
- References: <20141006125527 dot GC13369 at msticlxl57 dot ims dot intel dot com> <20141006141035 dot GZ1986 at tucnak dot redhat dot com> <20141009121523 dot GB81768 at msticlxl7 dot ims dot intel dot com> <20141009185105 dot GM1986 at tucnak dot redhat dot com> <20141010154719 dot GA121201 at msticlxl7 dot ims dot intel dot com>
- Reply-to: Jakub Jelinek <jakub at redhat dot com>
On Fri, Oct 10, 2014 at 07:47:19PM +0400, Ilya Tocar wrote:
> Updated patch below.
You haven't posted ChangeLog entry this time, so using the last one:
* config/i386/i386.c
(MAX_VECT_LEN): Move above ix86_expand_vec_perm_vpermi2.
...
* config/i386/sse.md
(define_mode_iterator VI1_AVX512): New.
I'd think you should avoid the line break after filename in these
cases, so
* config/i386/i386.c (MAX_VECT_LEN): Move above
ix86_expand_vec_perm_vpermi2.
...
* config/i386/sse.md (define_mode_iterator VI1_AVX512): New.
Other than that nit it looks good to me.
Jakub