This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [gofrontend-dev] [PATCH 5/9] Gccgo port to s390[x] -- part I
- From: Ian Lance Taylor <iant at golang dot org>
- To: vogt at linux dot vnet dot ibm dot com, Ian Lance Taylor <iant at golang dot org>, gcc-patches <gcc-patches at gcc dot gnu dot org>, "gofrontend-dev at googlegroups dot com" <gofrontend-dev at googlegroups dot com>
- Date: Thu, 9 Oct 2014 12:44:41 -0700
- Subject: Re: [gofrontend-dev] [PATCH 5/9] Gccgo port to s390[x] -- part I
- Authentication-results: sourceware.org; auth=none
- References: <20140909124446 dot GA25290 at linux dot vnet dot ibm dot com> <20140909125610 dot GF25290 at linux dot vnet dot ibm dot com> <CAKOQZ8wyFTKUEYkH+zFCvjdKOYFz9zxzpmkJktkgRwgG0gqbxA at mail dot gmail dot com> <20141006074230 dot GA19559 at linux dot vnet dot ibm dot com> <CAKOQZ8whD8k-uhMD3q8i+-5bfC_S2RMP98CrUTtD+sVEHACznQ at mail dot gmail dot com> <20141007104517 dot GA2739 at linux dot vnet dot ibm dot com>
On Tue, Oct 7, 2014 at 3:45 AM, Dominik Vogt <vogt@linux.vnet.ibm.com> wrote:
>
> The only points in that patch are that on one hand - as far as I
> know - the Abi does not guarantee that section symbols are either
> zero or not relocated, even if that may be the case in reality.
> And on the other hand, if that code is ever modified to handle
> non-section symbols, it's not obvious that you not only need to
> remove the test for the symbol type but also modify the
> calculations below. So, apply the patch or drop it as you like,
> but in any case, at least a comment in the code would improve
> maintainability.
I proposed this patch for the master repository:
https://codereview.appspot.com/155190043
Ian