This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
RE: [Patch, MIPS] Cleanup mips header files.
- From: Steve Ellcey <sellcey at mips dot com>
- To: Matthew Fortune <Matthew dot Fortune at imgtec dot com>
- Cc: "echristo at gmail dot com" <echristo at gmail dot com>, "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>, "rdsandiford at googlemail dot com" <rdsandiford at googlemail dot com>, "clm at codesourcery dot com" <clm at codesourcery dot com>
- Date: Wed, 8 Oct 2014 09:22:08 -0700
- Subject: RE: [Patch, MIPS] Cleanup mips header files.
- Authentication-results: sourceware.org; auth=none
- References: <057a8a56-4067-41bb-b806-e1280a0a69a2 at BAMAIL02 dot ba dot imgtec dot org> <6D39441BF12EF246A7ABCE6654B0235320F1DB6A at LEMAIL01 dot le dot imgtec dot org>
On Mon, 2014-10-06 at 14:25 -0700, Matthew Fortune wrote:
> Hi Steve,
>
> You're the lucky recipient of my first review so apologies for being
> slow and cautious...
>
> I tried to find a reason why the files were originally separated like this
> and I can't see anything obvious. I assume you also found no reason.
> Presumably the separation was just to avoid disturbing the 32-bit configs
> but I think it is a sensible move to merge them.
That was also my guess as to why it was done that way.
> With those changes can you double check that a default big and default little
> endian build pass -EB/-EL respectively by default and are changed when using
> -EL/-EB explicitly? There should only be one -E* option passed to the linker
> theoretically, unless multiple explicit -E* options are given on the command
> line.
I made the syntax changes, removed the '%{!EB:%{!EL:%(endian_spec)}}'
part of GNU_USER_TARGET_LINK_SPEC and double checked that we still pass
-EL or -EB to the linker in all cases.
> Otherwise OK (assuming the link specs behave as described above).
>
> Thanks,
> Matthew
Thanks for the review, I have gone ahead and checked in the patch with
those changes.
Steve Ellcey
sellcey@mips.com