This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] PR58867 ASan and UBSan tests not run for installed testing.
- From: Marcus Shawcroft <marcus dot shawcroft at gmail dot com>
- To: Maxim Ostapenko <m dot ostapenko at partner dot samsung dot com>
- Cc: GCC Patches <gcc-patches at gcc dot gnu dot org>, pinskia at gmail dot com, Jakub Jelinek <jakub at redhat dot com>, Yury Gribov <y dot gribov at samsung dot com>, Slava Garbuzov <v dot garbuzov at samsung dot com>, Maxim Ostapenko <chefmax7 at gmail dot com>
- Date: Wed, 8 Oct 2014 12:40:03 +0100
- Subject: Re: [PATCH] PR58867 ASan and UBSan tests not run for installed testing.
- Authentication-results: sourceware.org; auth=none
- References: <542BA26C dot 4000509 at partner dot samsung dot com> <542BA8C0 dot 2080509 at partner dot samsung dot com> <CAFqB+PyEzYw+7wuiSCvOty5KqMFDb+qVCZcXWK8Ax4qe1kkGrw at mail dot gmail dot com> <54350D97 dot 1020509 at partner dot samsung dot com>
On 8 October 2014 11:10, Maxim Ostapenko
<m.ostapenko@partner.samsung.com> wrote:
> Does it work without restore_ld_library_path in {asan, ubsan, tsan}_finish?
>
> I see two opportunities to fix the issue:
>
> 1) Implement a stack of saved contexts.
>
> 2) Implement new functions, say {asan, ubsan, tsan}_restore_ld_library_path,
> to be able {asan, ubsan, tsan}_finish functions restore context correctly.
>
> What solution is preferable?
Option 1 has the advantage that it places all of the context save and
restore in one place rather than spreading it around the
infrastructure.
Please can we revert this patch while a correct implementation is being worked?
Cheers
/Marcus