Re: [Patch ARM-AArch64/testsuite v2 01/21] Neon intrinsics execution tests initial framework.

[Christophe Lyon <christophe dot lyon at linaro dot org>]

On 10 July 2014 12:12, Marcus Shawcroft <marcus.shawcroft@gmail.com> wrote:
> On 1 July 2014 11:05, Christophe Lyon <christophe.lyon@linaro.org> wrote:
>> * documentation (README)
>> * dejanu driver (neon-intrinsics.exp)
>> * support macros (arm-neon-ref.h, compute-ref-data.h)
>> * Tests for 3 intrinsics: vaba, vld1, vshl
>
> Hi, The terminology in armv8 is advsimd rather than neon.  Can we
> rename neon-intrinsics to advsimd-intrinsics or simd-intrinsics
> throughout please.  The existing gcc.target/aarch64/simd directory of
> tests will presumably be superseded by this more comprehensive set of
> tests so I suggest these tests go in gcc.target/aarch64/advsimd and we
> eventually remove gcc.target/aarch64/simd/ directory.
>
> GNU style should apply throughout this patch series, notably double
> space after period in comments and README text.  Space before left
> parenthesis in function/macro call and function declaration.  The
> function name in a declaration goes on a new line.  The GCC wiki notes
> on test case state individual test should have file names ending in
> _<number>, see here https://gcc.gnu.org/wiki/TestCaseWriting
>

Hi,

For the record, these tests are based on a testsuite I wrote quite
some time ago:
https://gitorious.org/arm-neon-tests/

where obviously I had no such requirement (and v8 wasn't public yet)

So I prefer to apply the changes you request in my main version before
re-submitting it here.
(libsanitizer-style, sort-of....).

This will take me some time, so the next version of my patch series
should not be expected really soon :-(

Christophe.


> I'm OK with the execute only no scan nature of the tests.
>
>> diff --git a/gcc/testsuite/gcc.target/aarch64/neon-intrinsics/README b/gcc/testsuite/gcc.target/aarch64/neon-intrinsics/README
>> new file mode 100644
>> index 0000000..232bb1d
>> --- /dev/null
>> +++ b/gcc/testsuite/gcc.target/aarch64/neon-intrinsics/README
>> @@ -0,0 +1,132 @@
>> +This directory contains executable tests for ARM/AArch64 Neon
>> +intrinsics.
>
> Neon -> Advanced SIMD as below.
>
>> +
>> +It is meant to cover execution cases of all the Advanced SIMD
>> +intrinsics, but does not scan the generated assembler code.
>
>> +#if __BYTE_ORDER__ == __ORDER_LITTLE_ENDIAN__
>> +
>> +typedef union {
>> +  struct {
>
> GNUstyle { on new lne.
>
>> +#define Neon_Cumulative_Sat  __read_neon_cumulative_sat()
>> +#define Set_Neon_Cumulative_Sat(x)  __set_neon_cumulative_sat((x))
>
> Upper case the macro's rather than camel case.
>
>> +# Copyright (C) 2013 Free Software Foundation, Inc.
>
> s/13/14/
>
> Cheers
> /Marcus