This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH v3] PR libitm/61164: use always_inline consistently
- From: Torvald Riegel <triegel at redhat dot com>
- To: Jakub Jelinek <jakub at redhat dot com>
- Cc: Gleb Fotengauer-Malinovskiy <glebfm at altlinux dot org>, Richard Henderson <rth at redhat dot com>, gcc-patches at gcc dot gnu dot org
- Date: Mon, 29 Sep 2014 18:44:54 +0200
- Subject: Re: [PATCH v3] PR libitm/61164: use always_inline consistently
- Authentication-results: sourceware.org; auth=none
- References: <20140927120617 dot GA19658 at glebfm dot cloud dot tilaa dot com> <20140927170000 dot GB19878 at glebfm dot cloud dot tilaa dot com> <20140929085415 dot GB17454 at tucnak dot redhat dot com> <20140929125326 dot GD19878 at glebfm dot cloud dot tilaa dot com> <1412004924 dot 22112 dot 124 dot camel at triegel dot csb> <20140929153854 dot GG17454 at tucnak dot redhat dot com>
On Mon, 2014-09-29 at 17:38 +0200, Jakub Jelinek wrote:
> On Mon, Sep 29, 2014 at 05:35:24PM +0200, Torvald Riegel wrote:
> > On Mon, 2014-09-29 at 16:53 +0400, Gleb Fotengauer-Malinovskiy wrote:
> > > -#undef __always_inline
> > > -#define __always_inline __attribute__((always_inline))
> > > +#define __libitm_always_inline inline __attribute__((always_inline))
> >
> > The previous code seems to work in libstdc++. I believe that
> > eventually, we'll want to use libstdc++-v3/include/bits/atomic_base.h
> > (see the comment at the top of the file). Can we keep the diff between
> > the two files small?
>
> libstdc++-v3/include/bits/atomic_base.h uses
> _GLIBCXX_ALWAYS_INLINE macro:
>
> #ifndef _GLIBCXX_ALWAYS_INLINE
> #define _GLIBCXX_ALWAYS_INLINE inline __attribute__((always_inline))
> #endif
Ahh.. I missed that "inline" in there when I had a quick look. Sorry
for the noise :)