This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH C++] - SD-6 Implementation Part 1 - __has_include.


On 09/25/2014 12:57 PM, Jason Merrill wrote:
On 09/01/2014 09:34 PM, Ed Smith-Rowland wrote:
    (open_file_failed()): Not an error to not find a header file for
    __has_include__.

Hmm, looks like this means that __has_include__ will silently return false if a header exists but is unreadable; I would think that we want it to be true (and have an error when the user tries to include it).

Jason

Here is the new patch series.

A patch addressing C++11 [[deprecated]] is coming later when these are in as is a library patch for std::is_final.

I flipped the logic on the libcpp functions because there was a double negative of sorts - the logic was confusing to me on second look. Also, a file that a user can't read for permissions still returns true with __has_include.

Built and tested on x86_64-linux.

OK?

Attachment: CL_feature_test_1b
Description: Text document

Attachment: patch_feature_test_1b
Description: Text document

Attachment: CL_feature_test_2b
Description: Text document

Attachment: patch_feature_test_2b
Description: Text document

Attachment: CL_feature_test_3b
Description: Text document

Attachment: patch_feature_test_3b
Description: Text document

Attachment: CL_feature_test_4b
Description: Text document

Attachment: patch_feature_test_4b
Description: Text document


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]