Re: [COMMITTED][PATCH, 2/2] shrink wrap a function with a single loop: split live_edge

["H.J. Lu" <hjl dot tools at gmail dot com>]

On Fri, Sep 26, 2014 at 8:14 AM, Jiong Wang <jiong.wang@arm.com> wrote:
>
> On 26/09/14 16:05, H.J. Lu wrote:
>>
>> On Thu, Sep 25, 2014 at 9:43 AM, Jiong Wang <jiong.wang@arm.com> wrote:
>>>
>>> On 25/09/14 17:24, Jeff Law wrote:
>>>>
>>>> On 09/25/14 09:04, Jiong Wang wrote:
>>>>>
>>>>> new patch updated.
>>>>>
>>>>> pass bootstrap and no regression, both check-gcc and check-g++, on the
>>>>> x86.
>>>>>
>>>>> OK for trunk?
>>>>>
>>>>> thanks.
>>>>>
>>>>> gcc/
>>>>>       * shrink-wrap.c (move_insn_for_shrink_wrap): Initialize the
>>>>> live-in
>>>>> of
>>>>>       new created BB as the intersection of live-in from "old_dest" and
>>>>> live-out
>>>>>       from "bb".
>>>>
>>>> Please include a ChangeLog entry for the testsuite.  Something like:
>>>>
>>>>          * gcc.target/i386/shrink_wrap_1.c: New test.
>>
>> This fails on Linux/x86 and with -m32 on Linux/x86-64.
>
> sorry, my test machine is x86-64, I think the shrink wrap test itself is
> very fragile because
> it's highly related insn generated.
>
> could you mark that testcase using something like
> "dg-require-effective-target lp64"?

I checked in this patch to skip it on ia32.


-- 
H.J.
---
Index: ChangeLog
===================================================================
--- ChangeLog (revision 215644)
+++ ChangeLog (working copy)
@@ -1,3 +1,7 @@
+2014-09-26  H.J. Lu  <hongjiu.lu@intel.com>
+
+ * gcc.target/i386/shrink_wrap_1.c: Skip ia32.
+
 2014-09-26  Jakub Jelinek  <jakub@redhat.com>

  * g++.dg/compat/struct-layout-1_generate.c: Add -Wno-abi
Index: gcc.target/i386/shrink_wrap_1.c
===================================================================
--- gcc.target/i386/shrink_wrap_1.c (revision 215644)
+++ gcc.target/i386/shrink_wrap_1.c (working copy)
@@ -1,4 +1,4 @@
-/* { dg-do compile } */
+/* { dg-do compile { target { ! ia32 } } } */
 /* { dg-options "-O2 -fdump-rtl-pro_and_epilogue" } */

 enum machine_mode