This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH i386 AVX512] [49/n] Add vpshuf[lh]w insn patterns.
- From: Uros Bizjak <ubizjak at gmail dot com>
- To: Kirill Yukhin <kirill dot yukhin at gmail dot com>
- Cc: Jakub Jelinek <jakub at redhat dot com>, Richard Henderson <rth at redhat dot com>, GCC Patches <gcc-patches at gcc dot gnu dot org>
- Date: Tue, 23 Sep 2014 14:36:30 +0200
- Subject: Re: [PATCH i386 AVX512] [49/n] Add vpshuf[lh]w insn patterns.
- Authentication-results: sourceware.org; auth=none
- References: <20140923113005 dot GD41516 at msticlxl57 dot ims dot intel dot com>
On Tue, Sep 23, 2014 at 1:30 PM, Kirill Yukhin <kirill.yukhin@gmail.com> wrote:
> Bootstrapped.
> AVX-512* tests on top of patch-set all pass
> under simulator.
>
> Is it ok for trunk?
>
> gcc/
> * config/i386/sse.md
> (define_c_enum "unspec"): Add UNSPEC_PSHUFHW, UNSPEC_PSHUFLW.
> (define_insn "<mask_codefor>avx512bw_pshuflwv32hi<mask_name>"): New.
> (define_expand "avx512vl_pshuflwv3_mask"): Ditto.
> (define_insn "avx2_pshuflw_1<mask_name>"): Add masking.
> (define_expand "avx512vl_pshuflw_mask"): New.
> (define_insn "sse2_pshuflw_1<mask_name>"): Add masking.
> (define_insn "<mask_codefor>avx512bw_pshufhwv32hi<mask_name>"): New.
> (define_expand "avx512vl_pshufhwv3_mask"): Ditto.
> (define_insn "avx2_pshufhw_1<mask_name>"): Add masking.
> (define_expand "avx512vl_pshufhw_mask"): New.
> (define_insn "sse2_pshufhw_1<mask_name>"): Add masking.
OK, but please move mask checks nearby target checks, so we will have
consistent form of insn enable:
"TARGET_xxx && <mask_some_condition> && <mask_other_condition>"
&& ...
&& ..."
Thanks,
Uros.