This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [Ping] Port of VTV for Cygwin and MinGW

From: Jonathan Wakely <jwakely at redhat dot com>
To: Patrick Wollgast <patrick dot wollgast at rub dot de>
Cc: Caroline Tice <cmtice at google dot com>, bkoz at gnu dot org, ktietz at redhat dot com, GCC Patches <gcc-patches at gcc dot gnu dot org>, libstdc++ at gcc dot gnu dot org
Date: Tue, 23 Sep 2014 11:22:35 +0100
Subject: Re: [Ping] Port of VTV for Cygwin and MinGW
Authentication-results: sourceware.org; auth=none
References: <53FF0C8C dot 8090507 at rub dot de> <5411213F dot 1070104 at rub dot de> <CABtf2+RU7frwOXOX2FF8Tmfc6ssrpfFVj1Vuue4cZt19FpSWtQ at mail dot gmail dot com> <CABtf2+QWxvv1FUW_-kD3d0FBhYQWkZcPWAx8ASies_4j7thmoA at mail dot gmail dot com> <541B5B7E dot 2090300 at rub dot de>

On 19/09/14 00:23 +0200, Patrick Wollgast wrote:

Index: libstdc++-v3/acinclude.m4
===================================================================
--- libstdc++-v3/acinclude.m4	(Revision 214408)
+++ libstdc++-v3/acinclude.m4	(Arbeitskopie)
@@ -2321,7 +2321,17 @@ AC_DEFUN([GLIBCXX_ENABLE_VTABLE_VERIFY],
  AC_MSG_RESULT([$enable_vtable_verify])

  if test $enable_vtable_verify = yes; then
+    case ${target_os} in
+  cygwin*|mingw32*)
+    VTV_CXXFLAGS="-fvtable-verify=std -Wl,-lvtv,-u_vtable_map_vars_start,-u_vtable_map_vars_end"
+    vtv_cygmin="yes"
+    ;;
+  *)
    VTV_CXXFLAGS="-fvtable-verify=std -Wl,-u_vtable_map_vars_start,-u_vtable_map_vars_end"
+    vtv_cygmin="no"
+    ;;
+    esac
+    AM_CONDITIONAL(VTV_CYGMIN, test $vtv_cygmin = yes)
    VTV_PCH_CXXFLAGS="-fvtable-verify=std"
    VTV_CXXLINKFLAGS="-L${toplevel_builddir}/libvtv/.libs -Wl,--rpath -Wl,${toplevel_builddir}/libvtv/.libs"		
  else


The lines between case and esac should be indented by four more
spaces.

Apart from that the libstdc++ changes are OK and I'll approve them.

Follow-Ups:
- Re: [Ping] Port of VTV for Cygwin and MinGW
  - From: Patrick Wollgast

References:
- [Ping] Port of VTV for Cygwin and MinGW
  - From: Patrick Wollgast
- Re: [Ping] Port of VTV for Cygwin and MinGW
  - From: Caroline Tice
- Re: [Ping] Port of VTV for Cygwin and MinGW
  - From: Patrick Wollgast

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]