This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH AArch64]: Add constraint letter for stack_protect_test pattern)
- From: Jakub Jelinek <jakub at redhat dot com>
- To: Marcus Shawcroft <marcus dot shawcroft at gmail dot com>
- Cc: James Greenhalgh <james dot greenhalgh at arm dot com>, "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>, venkataramanan dot kumar at linaro dot org, pinskia at gmail dot com
- Date: Thu, 18 Sep 2014 11:05:46 +0200
- Subject: Re: [PATCH AArch64]: Add constraint letter for stack_protect_test pattern)
- Authentication-results: sourceware.org; auth=none
- References: <541946A7 dot 8080407 at arm dot com> <1410964981-32412-1-git-send-email-james dot greenhalgh at arm dot com> <CAFqB+PyzWPrH9KpRbWuosdc3a7Dd-_Hhsi4SiAsHpCxtcE0HBA at mail dot gmail dot com>
- Reply-to: Jakub Jelinek <jakub at redhat dot com>
On Thu, Sep 18, 2014 at 09:18:53AM +0100, Marcus Shawcroft wrote:
> > gcc/testsuite/
> >
> > 2014-09-15 James Greenhalgh <james.greenhalgh@arm.com>
> >
> > * gcc.target/aarch64/stack_protector_set_1.c: New.
> > * gcc.target/aarch64/stack_protector_set_2.c: Likewise.
>
> I agree with Andrew, these don't need to be aarch64 specific.
Well, guess the 16 needs to be replaced with sizeof buffer, because
sizeof (unsigned int) is not 4 on all architectures.
And
/* { dg-require-effective-target fstack_protector } */
is needed, not all targets support -fstack-protector*.
Jakub